Skip to content

Commit 681190d

Browse files
[47] Fix browserVersion errors due to missing additionalCapability obj key
1 parent 2237b07 commit 681190d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "testcafe-browser-provider-lambdatest",
3-
"version": "2.0.25",
3+
"version": "2.0.27",
44
"description": "lambdatest TestCafe browser provider plugin.",
55
"repository": "https://github.com/LambdaTest/testcafe-browser-provider-lambdatest",
66
"homepage": "https://github.com/LambdaTest/testcafe-browser-provider-lambdatest",

src/util.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,12 +282,9 @@ async function _parseCapabilities (id, capability) {
282282

283283
if (browserName && browserName.trim().toLowerCase() === 'safari' && browserVersion && browserVersion.split('.')[0] > 11 && !('enableCustomTranslation' in capabilities[id])) capabilities[id].enableCustomTranslation = true;
284284

285-
if (!browserVersion || browserVersion === 'any') {
286-
285+
if (!browserVersion || browserVersion === 'any' && additionalCapabilities[capability] !== undefined) {
287286
const browserVersionKey = additionalCapabilities[capability]['browserVersion'];
288-
289287
if (browserName && browserName.trim().toLowerCase() === 'firefox' && browserVersionKey && browserVersionKey.split('.')[0] > 47 && !('enableCustomTranslation' in capabilities[id])) capabilities[id].enableCustomTranslation = true;
290-
291288
if (browserName && browserName.trim().toLowerCase() === 'safari' && browserVersionKey && browserVersionKey.split('.')[0] > 11 && !('enableCustomTranslation' in capabilities[id])) capabilities[id].enableCustomTranslation = true;
292289

293290

0 commit comments

Comments
 (0)