Skip to content

Commit 70506d7

Browse files
committed
changes for session remarks
1 parent dc8eff4 commit 70506d7

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "wdio-lambdatest-service",
3-
"version": "3.0.0",
3+
"version": "3.0.1",
44
"description": "A WebdriverIO service that manages tunnel and job metadata for LambdaTest.",
55
"author": "LambdaTest <[email protected]>",
66
"contributors": [

src/service.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export default class LambdaRestService implements Services.ServiceInstance {
1919
private _testCnt;
2020
private _testTitle?;
2121
private _currrentTestTitle;
22+
private _ltErrorRemark?: boolean;
2223

2324
constructor(options: LTOptions & SessionNameOptions, capabilities: Capabilities.RemoteCapability, config: Options.Testrunner);
2425
before(caps: Capabilities.RemoteCapability, specs: string[], browser: Browser<'async'> | MultiRemoteBrowser<'async'>): Promise<void>;
@@ -62,4 +63,5 @@ export default class LambdaRestService implements Services.ServiceInstance {
6263
_setSessionName(sessionName: string): Promise<void>;
6364
_executeCommand(cmd: string): Promise<void>;
6465
getSessionURL(sessionId: string, product: string): string;
66+
_setSessionRemarks(err: string): Promise<void>;
6567
}

src/service.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -395,14 +395,21 @@ export default class LambdaRestService {
395395
}
396396
}
397397

398-
async _setSessionRemarks(err){
399-
let replacedString = err.replace(/"/g, "'");
400-
let errorCustom =`lambda-hook: {"action": "setTestStatus","arguments": {"status":"failed","remark":"${replacedString}"}}`;
398+
async _setSessionRemarks(err) {
401399
try {
400+
const hookObject = {
401+
action: "setTestStatus",
402+
arguments: {
403+
status: "failed",
404+
remark: err
405+
}
406+
};
407+
408+
const errorCustom = `lambda-hook: ${JSON.stringify(hookObject)}`;
402409
await this._browser.execute(errorCustom);
403410
} catch (error) {
404-
console.log(error)
405-
}
411+
console.log("Error setting session remarks:", error);
412+
}
406413
}
407414

408415
async _setSessionName(sessionName) {

0 commit comments

Comments
 (0)