Skip to content

Commit e2842a8

Browse files
committed
picked["value"] is actually safe, add a comment explaining why
1 parent daeeb62 commit e2842a8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pets-gd/classes/dbox.gd

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ func say_as_with_choices(speaker, msgs, dchoices, do_open = true, do_close = tru
2222
if do_close:
2323
close()
2424

25-
# TODO: bruh wtf are you doing, `value` is locale-dependant
25+
# NOTE: `value` is NOT locale-dependant. it's safe to use as long as you compare
26+
# against tr keys and not regular strings. The reason you see regular strings in
27+
# debug menus is because adding localization for that is usually a waste of time.
2628
return { "index": index, "value": dchoices[index] if dchoices.size() > 0 else null }
2729

2830
func say_as(speaker, msgs, do_open = true, do_close = true):

0 commit comments

Comments
 (0)