Skip to content

Commit 690f0ab

Browse files
committed
Update main_release.yml
Stopped trying to use Akeyless dynamic secret and just setup a new SP and used GH Secrets instead.
1 parent 09ab4fb commit 690f0ab

File tree

1 file changed

+15
-30
lines changed

1 file changed

+15
-30
lines changed

.github/workflows/main_release.yml

Lines changed: 15 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -144,24 +144,9 @@ jobs:
144144
name: Upload Tests (Service Principal credentials)
145145
runs-on: windows-latest
146146
needs: LargeFileCount_Test
147-
env:
148-
# Set in Settings->Secrets->Actions
149-
SECRET_PATH: ${{vars.AKEYLESS_SECRET_PATH}}
150-
ACCESS_ID: ${{vars.AKEYLESS_ACCESS_ID}}
151-
ACCESS_KEY: ${{secrets.AKEYLESS_ACCESS_KEY}}
152147
steps:
153148
- uses: actions/checkout@v5
154149

155-
# I am using an Akeyless dynamic secret to gte my Service Principal details.
156-
# This is not common, you can use your own explicitly generated Service Principal credentials as GitHub secrets instead.
157-
- name: Generate temp Service Principal credentials (via Akeyless dynamic secret)
158-
id: aad-secret
159-
uses: LanceMcCarthy/akeyless-aad-secret@v1
160-
with:
161-
akeyless-secret-path: '${{env.SECRET_PATH}}'
162-
akeyless-access-id: '${{env.ACCESS_ID}}'
163-
akeyless-access-key: '${{env.ACCESS_KEY}}'
164-
165150
- name: Generating Unique File Names for This Run
166151
run: |
167152
$date = Get-Date -Format "yyyy.Mdd.hh.mm"
@@ -182,9 +167,9 @@ jobs:
182167
- name: Upload without DestinationFolder Test
183168
uses: ./
184169
with:
185-
tenant_id: "${{steps.aad-secret.outputs.tenant-id}}"
186-
client_id: "${{steps.aad-secret.outputs.app-id}}"
187-
client_secret: "${{steps.aad-secret.outputs.secret-text}}"
170+
tenant_id: "${{secrets.AZURE_TENANT_ID}}"
171+
client_id: "${{secrets.AZURE_CLIENT_ID}}"
172+
client_secret: "${{secrets.AZURE_CLIENT_SECRET}}"
188173
storage_account: "dvlup"
189174
container_name: ci-cd
190175
source_folder: TestFiles\ExcelFiles\
@@ -195,9 +180,9 @@ jobs:
195180
- name: Recursive with DestinationFolder Test
196181
uses: ./
197182
with:
198-
tenant_id: "${{steps.aad-secret.outputs.tenant-id}}"
199-
client_id: "${{steps.aad-secret.outputs.app-id}}"
200-
client_secret: "${{steps.aad-secret.outputs.secret-text}}"
183+
tenant_id: "${{secrets.AZURE_TENANT_ID}}"
184+
client_id: "${{secrets.AZURE_CLIENT_ID}}"
185+
client_secret: "${{secrets.AZURE_CLIENT_SECRET}}"
201186
storage_account: "dvlup"
202187
container_name: ci-cd
203188
source_folder: TestFiles\TxtFiles\
@@ -209,9 +194,9 @@ jobs:
209194
- name: Non-recursive with Destination Folder Test
210195
uses: ./
211196
with:
212-
tenant_id: "${{steps.aad-secret.outputs.tenant-id}}"
213-
client_id: "${{steps.aad-secret.outputs.app-id}}"
214-
client_secret: "${{steps.aad-secret.outputs.secret-text}}"
197+
tenant_id: "${{secrets.AZURE_TENANT_ID}}"
198+
client_id: "${{secrets.AZURE_CLIENT_ID}}"
199+
client_secret: "${{secrets.AZURE_CLIENT_SECRET}}"
215200
storage_account: "dvlup"
216201
container_name: ci-cd
217202
source_folder: TestFiles\TxtFiles\
@@ -224,9 +209,9 @@ jobs:
224209
- name: Non-recursive with Destination Folder Test (with '.' Prefix)
225210
uses: ./
226211
with:
227-
tenant_id: "${{steps.aad-secret.outputs.tenant-id}}"
228-
client_id: "${{steps.aad-secret.outputs.app-id}}"
229-
client_secret: "${{steps.aad-secret.outputs.secret-text}}"
212+
tenant_id: "${{secrets.AZURE_TENANT_ID}}"
213+
client_id: "${{secrets.AZURE_CLIENT_ID}}"
214+
client_secret: "${{secrets.AZURE_CLIENT_SECRET}}"
230215
storage_account: "dvlup"
231216
container_name: ci-cd
232217
source_folder: .\TestFiles\ExcelFiles\
@@ -239,9 +224,9 @@ jobs:
239224
- name: Single File Path Test
240225
uses: ./
241226
with:
242-
tenant_id: "${{steps.aad-secret.outputs.tenant-id}}"
243-
client_id: "${{steps.aad-secret.outputs.app-id}}"
244-
client_secret: "${{steps.aad-secret.outputs.secret-text}}"
227+
tenant_id: "${{secrets.AZURE_TENANT_ID}}"
228+
client_id: "${{secrets.AZURE_CLIENT_ID}}"
229+
client_secret: "${{secrets.AZURE_CLIENT_SECRET}}"
245230
storage_account: "dvlup"
246231
container_name: ci-cd
247232
source_folder: TestFiles\build\bin\data-composer-0.0.0.exe

0 commit comments

Comments
 (0)