govukRebrand global not being honored by header and footer macros

[jwlademann]

The govukRebrand global only seems to be partially working. It's getting picked up by the main template and setting the colour scheme, but the footer and header don't seem to acknowledge it properly, so I'm having to set "rebrand" to true for those components in addition to govukRebrand.

I believe these line aren't working as intended:

govuk-frontend-jinja/govuk_frontend_jinja/templates/components/header/macro.html

Line 5 in f7a737c

{%- set _rebrand = params.rebrand | default(govukRebrand() if govukRebrand and govukRebrand is callable else govukRebrand) -%}

govuk-frontend-jinja/govuk_frontend_jinja/templates/components/footer/macro.html

Line 5 in f7a737c

{%- set _rebrand = params.rebrand | default(govukRebrand() if govukRebrand and govukRebrand is callable else govukRebrand) -%}

Unless I'm missing something, or this is intentional?

[markhobson]

Hi @jwlademann, it's a bit subtle but by default Jinja macros don't have access to the global context, so these lines won't pick up govukRebrand. You either have to import them with explicit access to the context:

{% from "govuk_frontend_jinja/components/header/macro.html" import govukHeader with context -%}

Or pass it through as a parameter:

{{ govukHeader({
   'rebrand': govukRebrand
}) }}