Refactor kubetap-entrypoint.sh and Dockerfile to ensure .mitmproxy directory is created with proper permissions before copying the config file

Author: Lappihuan

proxies/mitmproxy/Dockerfile

@@ -8,11 +8,13 @@ RUN apt-get update && \
 
 # HACK: the security context of the injected pod could be run as any user, therefore
 # all users must be able to write to the directory.
-RUN chmod -R 777 /home/mitmproxy/.mitmproxy/
+# Ensure the directory exists and is world-writable
+RUN mkdir -p /home/mitmproxy/.mitmproxy && \
+    chmod -R 777 /home/mitmproxy/.mitmproxy/
 
 # Hijack the mitmproxy entrypoint (docker-entrypoint.sh) so that
 # configuration can be built from within the container using the
 # kubetap binary.
 
 COPY kubetap-entrypoint.sh /usr/local/bin/
-ENTRYPOINT ["kubetap-entrypoint.sh"]
+ENTRYPOINT ["kubetap-entrypoint.sh"]

proxies/mitmproxy/kubetap-entrypoint.sh

@@ -4,18 +4,17 @@ set -o errexit
 set -o pipefail
 set -o nounset
 
-# HACK: this fixes permission issues
-# Ensure the .mitmproxy directory exists and is writable
-if [ -d /home/mitmproxy/.mitmproxy ] && [ -w /home/mitmproxy/.mitmproxy ]; then
-  # Only copy the config file if it exists and we have read access
-  if [ -f /home/mitmproxy/config/config.yaml ] && [ -r /home/mitmproxy/config/config.yaml ]; then
-    cp /home/mitmproxy/config/config.yaml /home/mitmproxy/.mitmproxy/config.yaml
-    echo "Config file copied to /home/mitmproxy/.mitmproxy/config.yaml" >&2
-  else
-    echo "Warning: Config file not found or not readable at /home/mitmproxy/config/config.yaml" >&2
-  fi
+# Ensure the .mitmproxy directory exists with proper permissions
+mkdir -p /home/mitmproxy/.mitmproxy
+chmod 777 /home/mitmproxy/.mitmproxy
+
+# Copy the config file if it exists and is readable
+if [ -f /home/mitmproxy/config/config.yaml ] && [ -r /home/mitmproxy/config/config.yaml ]; then
+  cp /home/mitmproxy/config/config.yaml /home/mitmproxy/.mitmproxy/config.yaml
+  chmod 666 /home/mitmproxy/.mitmproxy/config.yaml
+  echo "Config file copied to /home/mitmproxy/.mitmproxy/config.yaml" >&2
 else
-  echo "Warning: .mitmproxy directory not found or not writable" >&2
+  echo "Warning: Config file not found or not readable at /home/mitmproxy/config/config.yaml" >&2
 fi
 
 prog="${1}"