Skip to content

Commit 8518ce7

Browse files
committed
moved payload & representation creators to implementations
1 parent 78e059d commit 8518ce7

File tree

7 files changed

+13
-191
lines changed

7 files changed

+13
-191
lines changed

spec/Factory/VersionFactorySpec.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
use Illuminate\Contracts\Container\Container as App;
66
use LaraPackage\Api\Contracts\Request\Payload;
7-
use LaraPackage\Api\PayloadCreator;
8-
use LaraPackage\Api\RepresentationCreator;
7+
use LaraPackage\Api\Implementations\PayloadCreator;
8+
use LaraPackage\Api\Implementations\RepresentationCreator;
99
use PhpSpec\ObjectBehavior;
1010
use Prophecy\Argument;
1111

@@ -29,13 +29,13 @@ function it_makes_a_media_type()
2929

3030
function it_makes_a_payload_creator(App $app, PayloadCreator $payloadCreator)
3131
{
32-
$app->make(\LaraPackage\Api\PayloadCreator::class)->shouldBeCalled()->willReturn($payloadCreator);
32+
$app->make(\LaraPackage\Api\Implementations\PayloadCreator::class)->shouldBeCalled()->willReturn($payloadCreator);
3333
$this->makePayloadCreator()->shouldReturn($payloadCreator);
3434
}
3535

3636
function it_makes_a_representation_creator(App $app, RepresentationCreator $responseCreator)
3737
{
38-
$app->make(\LaraPackage\Api\RepresentationCreator::class)->shouldBeCalled()->willReturn($responseCreator);
38+
$app->make(\LaraPackage\Api\Implementations\RepresentationCreator::class)->shouldBeCalled()->willReturn($responseCreator);
3939
$this->makeRepresentationCreator()->shouldReturn($responseCreator);
4040
}
4141

spec/PayloadCreatorSpec.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ function it_builds_an_entity_resource(
7676

7777
function it_is_initializable()
7878
{
79-
$this->shouldHaveType('LaraPackage\Api\PayloadCreator');
79+
$this->shouldHaveType('LaraPackage\Api\Implementations\PayloadCreator');
8080
}
8181

8282
function it_returns_an_empty_collection_for_no_results(

spec/RepresentationCreatorSpec.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class RepresentationCreatorSpec extends ObjectBehavior
1111

1212
function it_is_initializable()
1313
{
14-
$this->shouldHaveType('LaraPackage\Api\RepresentationCreator');
14+
$this->shouldHaveType('LaraPackage\Api\Implementations\RepresentationCreator');
1515
}
1616

1717
function it_makes_a_response(

src/Implementations/PayloadCreator.php

100755100644
Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
<?php
22
namespace LaraPackage\Api\Implementations;
33

4-
use InvalidArgumentException;
5-
use LaraPackage\Api\Contracts\Factory\VersionFactory;
6-
use LaraPackage\Api\Contracts\Request\Parser;
4+
use LaraPackage\Api\Exceptions\InvalidArgumentException;
75
use LaraPackage\Api\FractalFactory;
86
use League\Fractal;
97

@@ -17,21 +15,20 @@ class PayloadCreator implements \LaraPackage\Api\Contracts\PayloadCreator
1715
protected $payload;
1816

1917
/**
20-
* @var Parser
18+
* @var \LaraPackage\Api\Contracts\Request\Parser
2119
*/
2220
protected $requestParser;
2321

2422
/**
2523
* @var FractalFactory
2624
*/
2725
protected $fractalFactory;
28-
2926
/**
30-
* @var VersionFactory
27+
* @var \LaraPackage\Api\Contracts\Factory\VersionFactory
3128
*/
3229
private $versionFactory;
3330

34-
public function __construct(\LaraPackage\Api\Contracts\Request\Parser $requestParser, FractalFactory $fractalFactory, VersionFactory $versionFactory)
31+
public function __construct(\LaraPackage\Api\Contracts\Request\Parser $requestParser, FractalFactory $fractalFactory, \LaraPackage\Api\Contracts\Factory\VersionFactory $versionFactory)
3532
{
3633
$this->requestParser = $requestParser;
3734
$this->fractalFactory = $fractalFactory;

src/Implementations/RepresentationCreator.php

100755100644
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class RepresentationCreator implements \LaraPackage\Api\Contracts\Representation
2020
/**
2121
* @var int
2222
*/
23-
private $version = 4;
23+
private $version = 1;
2424
/**
2525
* @var \LaraPackage\Api\Contracts\Config\ApiVersion
2626
*/
@@ -31,7 +31,8 @@ public function __construct(
3131
ResponseFactory $response,
3232
\LaraPackage\Api\Contracts\Factory\VersionFactory $versionFactory,
3333
\LaraPackage\Api\Contracts\Config\ApiVersion $versionInfoRetriever
34-
) {
34+
)
35+
{
3536
$this->requestParser = $requestParser;
3637
$this->response = $response;
3738
$this->versionFactory = $versionFactory;

src/PayloadCreator.php

Lines changed: 0 additions & 105 deletions
This file was deleted.

src/RepresentationCreator.php

Lines changed: 0 additions & 71 deletions
This file was deleted.

0 commit comments

Comments
 (0)