Merge pull request #4177 from bomshteyn/patch-1

tabacitu · web-flow · commit 0ad069c860ea · 2022-02-11T08:59:16.000+02:00
The set is expecting wrong param type
diff --git a/src/app/Library/CrudPanel/Traits/Settings.php b/src/app/Library/CrudPanel/Traits/Settings.php
@@ -26,7 +26,7 @@ public function get(string $key)
      * Setter for the settings key-value store.
      *
      * @param  string  $key  Usually operation.name (ex: reorder.max_level)
-     * @param  bool  $value  True/false depending on success.
+     * @param  string  $value  The value being set
      */
     public function set(string $key, $value)
     {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function get(string $key)`
`26`	`26`	`* Setter for the settings key-value store.`
`27`	`27`	`*`
`28`	`28`	`* @param string $key Usually operation.name (ex: reorder.max_level)`
`29`		`- * @param bool $value True/false depending on success.`
	`29`	`+ * @param string $value The value being set`
`30`	`30`	`*/`
`31`	`31`	`public function set(string $key, $value)`
`32`	`32`	`{`