Merge pull request #4914 from Laravel-Backpack/laravel-v10

Add Laravel 10 Support

Author: pxpm

.github/workflows/coverage.yml

@@ -24,13 +24,13 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.1
+          php-version: 8.2
           extensions: curl, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, iconv, xdebug
           coverage: xdebug
           tools: composer:v2
       - name: Install dependencies
         run: |
-            composer require "laravel/framework:^9.0" "phpunit/phpunit:^9.0" "doctrine/dbal:^3.0" --no-interaction --no-update --no-suggest
+            composer require "laravel/framework:^10.0" "phpunit/phpunit:^9.0" "doctrine/dbal:^3.0" --no-interaction --no-update --no-suggest
             composer update --prefer-dist --no-interaction
       - name: Execute tests
         run: vendor/bin/phpunit --coverage-clover coverage.xml

.github/workflows/testing.yml

@@ -21,7 +21,7 @@ jobs:
                 # os: [ubuntu-latest, macos-latest, windows-latest]
                 php: [7.3, 7.4, 8.0, 8.1, 8.2]
                 dbal: [^2.5, ^3.0]
-                laravel: [8.*, 9.*]
+                laravel: [8.*, 9.*, 10.*]
                 phpunit: [8.*, 9.*]
                 dependency-version: [stable] # to add: lowest
                 exclude:
@@ -31,6 +31,17 @@ jobs:
                       php: 7.4
                     - laravel: 9.*
                       phpunit: 8.*
+                    - laravel: 10.*
+                      php: 7.3
+                    - laravel: 10.*
+                      php: 7.4
+                    - laravel: 10.*
+                      php: 8.0
+                    - laravel: 10.*
+                      phpunit: 8.*
+                    - laravel: 10.*
+                      dbal: ^2.5
+        
 
         name: PHP ${{ matrix.php }}, Laravel ${{ matrix.laravel }}, PHPUnit ${{ matrix.phpunit }}, DBAL ${{ matrix.dbal }} --prefer-${{ matrix.dependency-version }}
 

README.md

@@ -80,7 +80,7 @@ Start with the ["Introduction" page in our docs](https://backpackforlaravel.com/
 ## Install
 
 For the current version (recommended):
-- [Install Backpack v5 on Laravel 9 or 8](https://backpackforlaravel.com/docs/5.x/installation);
+- [Install Backpack v5 on Laravel 10, 9 or 8](https://backpackforlaravel.com/docs/5.x/installation);
 
 For the previous versions (not recommended):
 - [Install Backpack 4.1 on Laravel 6, 7 or 8](https://backpackforlaravel.com/docs/4.1/installation) - last feature update was 1st Jan 2021;

composer.json

@@ -32,7 +32,7 @@
         }
     ],
     "require": {
-        "laravel/framework": "^9.0|^8.69",
+        "laravel/framework": "^10.0|^9.0|^8.69",
         "prologue/alerts": "^1.0|^0.4",
         "digitallyhappy/assets": "^2.0.1",
         "creativeorange/gravatar": "~1.0",
@@ -43,7 +43,7 @@
     "require-dev": {
         "phpunit/phpunit": "~8.0|~7.0|~9.0",
         "scrutinizer/ocular": "~1.7|~1.1",
-        "orchestra/testbench": "^7.0|^6.0|^5.0|^4.0|^3.0",
+        "orchestra/testbench": "^8.0|^7.0|^6.0|^5.0|^4.0|^3.0",
         "spatie/laravel-translatable": "^4.0|^5.0|^6.0"
     },
     "autoload": {

src/app/Console/Commands/Addons/RequireDevTools.php

@@ -30,11 +30,11 @@ class RequireDevTools extends Command
      * @var array
      */
     public static $addon = [
-        'name' => 'DevTools',
+        'name'        => 'DevTools',
         'description' => [
             'Helps generate models, migrations, operations and CRUDs',
         ],
-        'path' => 'vendor/backpack/devtools',
+        'path'    => 'vendor/backpack/devtools',
         'command' => 'backpack:require:devtools',
     ];
 
@@ -45,6 +45,15 @@ class RequireDevTools extends Command
      */
     public function handle()
     {
+        // Prevent installations in laravel 10 as it wouldn't properly work. Waiting for Blueprint L10 support.
+        if (app()->version() >= 10) {
+            $this->newLine();
+            $this->line(sprintf('Support for Laravel 10 is comming soon. Sorry for the trouble.'), 'fg=red');
+            $this->newLine();
+
+            return;
+        }
+
         // Check if it is installed
         if ($this->isInstalled()) {
             $this->newLine();

src/app/Models/Traits/HasEnumFields.php

@@ -15,14 +15,18 @@ trait HasEnumFields
 {
     public static function getPossibleEnumValues($field_name)
     {
-        $default_connection = Config::get('database.default');
-        $table_prefix = Config::get('database.connections.'.$default_connection.'.prefix');
-
         $instance = new static(); // create an instance of the model to be able to get the table name
-        $connectionName = $instance->getConnectionName();
+
+        $connection = $instance->getConnection();
+
+        $table_prefix = Config::get('database.connections.'.$connection->getName().'.prefix');
 
         try {
-            $type = DB::connection($connectionName)->select(DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"'))[0]->Type;
+            $select = app()->version() < 10 ?
+                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"') :
+                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"')->getValue($connection->getQueryGrammar());
+
+            $type = $connection->select($select)[0]->Type;
         } catch (\Exception $e) {
             abort(500, 'Enum field type is not supported - it only works on MySQL. Please use select_from_array instead.');
         }