add more tests

Author: pxpm

src/BackpackServiceProvider.php

@@ -163,6 +163,11 @@ public function publishFiles()
      */
     public function setupRoutes(Router $router)
     {
+        if (app()->runningUnitTests()) {
+            $this->loadRoutesFrom(__DIR__.'/routes/backpack/testing.php');
+
+            return;
+        }
         // by default, use the routes file provided in vendor
         $routeFilePathInUse = __DIR__.$this->routeFilePath;
 

src/app/Http/Controllers/CrudController.php

@@ -33,14 +33,13 @@ public function __construct()
         // It's done inside a middleware closure in order to have
         // the complete request inside the CrudPanel object.
         $this->middleware(function ($request, $next) {
-            $this->crud = app()->make('crud');
+            $this->crud = app('crud');
 
             $this->crud->setRequest($request);
 
             $this->setupDefaults();
             $this->setup();
             $this->setupConfigurationForCurrentOperation();
-
             return $next($request);
         });
     }
@@ -96,6 +95,7 @@ protected function setupDefaults()
     protected function setupConfigurationForCurrentOperation()
     {
         $operationName = $this->crud->getCurrentOperation();
+        
         $setupClassName = 'setup'.Str::studly($operationName).'Operation';
 
         /*
@@ -109,7 +109,7 @@ protected function setupConfigurationForCurrentOperation()
          * write is done after the default, so you can remove default settings, etc;
          */
         $this->crud->applyConfigurationFromSettings($operationName);
-
+        
         /*
          * THEN, run the corresponding setupXxxOperation if it exists.
          */

src/app/Library/CrudPanel/CrudPanel.php

@@ -148,6 +148,7 @@ private function getSchema()
      * DEPRECATION NOTICE: This method is no longer used and will be removed in future versions of Backpack
      *
      * @deprecated
+     * @codeCoverageIgnore
      *
      * @return bool
      */
@@ -307,16 +308,18 @@ public function getFirstOfItsTypeInArray($type, $array)
         });
     }
 
-    // ------------
-    // TONE FUNCTIONS - UNDOCUMENTED, UNTESTED, SOME MAY BE USED IN THIS FILE
-    // ------------
-    //
-    // TODO:
-    // - figure out if they are really needed
-    // - comments inside the function to explain how they work
-    // - write docblock for them
-    // - place in the correct section above (CREATE, READ, UPDATE, DELETE, ACCESS, MANIPULATION)
-
+    /**
+     * TONE FUNCTIONS - UNDOCUMENTED, UNTESTED, SOME MAY BE USED IN THIS FILE
+     *
+     * TODO:
+     * - figure out if they are really needed
+     * - comments inside the function to explain how they work
+     * - write docblock for them
+     * - place in the correct section above (CREATE, READ, UPDATE, DELETE, ACCESS, MANIPULATION)
+     *
+     * @deprecated
+     * @codeCoverageIgnore
+     */
     public function sync($type, $fields, $attributes)
     {
         if (! empty($this->{$type})) {

src/app/Library/CrudPanel/Traits/HasViewNamespaces.php

@@ -4,6 +4,9 @@
 
 use Backpack\CRUD\ViewNamespaces;
 
+/**
+ * @codeCoverageIgnore
+ */
 trait HasViewNamespaces
 {
     /**

src/app/Library/CrudPanel/Traits/SaveActions.php

@@ -212,7 +212,7 @@ public function orderSaveActions(array $saveActions)
     /**
      * Return the ordered save actions to use in the crud panel.
      *
-     * @return void
+     * @return array
      */
     public function getOrderedSaveActions()
     {
@@ -228,7 +228,7 @@ public function getOrderedSaveActions()
     /**
      * Returns the save actions that passed the visible callback.
      *
-     * @return void
+     * @return array
      */
     public function getVisibleSaveActions()
     {

src/routes/backpack/testing.php

@@ -0,0 +1,21 @@
+<?php
+
+use Illuminate\Support\Facades\Route;
+
+/*
+|--------------------------------------------------------------------------
+| Backpack Testing Routes
+|--------------------------------------------------------------------------
+| This routes are loaded only when running unit tests.
+|
+*/
+
+Route::group([
+    (array) config('backpack.base.web_middleware', 'web'),
+    (array) config('backpack.base.middleware_key', 'admin'),
+    'prefix'     => config('backpack.base.route_prefix', 'admin'),
+],
+    function () {
+        Route::crud('users', 'Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController');
+    }
+);