Merge pull request #4512 from Laravel-Backpack/fix-column-attribute-for-filters

[Bug] Fix column attribute for filters

Author: tabacitu

src/app/Library/CrudPanel/Traits/Columns.php

@@ -372,6 +372,12 @@ public function makeSureColumnHasNeededAttributes($column)
             $column['relation_type'] = $this->inferRelationTypeFromRelationship($column);
         }
 
+        // if there's a model defined, but no attribute
+        // guess an attribute using the identifiableAttribute functionality in CrudTrait
+        if (isset($column['model']) && ! isset($column['attribute']) && method_exists($column['model'], 'identifiableAttribute')) {
+            $column['attribute'] = (new $column['model'])->identifiableAttribute();
+        }
+
         // check if the column exists in the database (as a db column)
         $column_exists_in_db = $this->hasDatabaseColumn($this->model->getTable(), $column['name']);
 

tests/Unit/CrudPanel/CrudPanelColumnsTest.php

@@ -128,6 +128,7 @@ class CrudPanelColumnsTest extends BaseDBCrudPanelTest
             'entity'      => 'accountDetails',
             'model'       => 'Backpack\CRUD\Tests\Unit\Models\AccountDetails',
             'relation_type' => 'HasOne',
+            'attribute'   => 'nickname',
         ],
         'accountDetails__nickname' => [
             'name'        => 'accountDetails.nickname',
@@ -155,6 +156,7 @@ class CrudPanelColumnsTest extends BaseDBCrudPanelTest
             'relation_type' => 'BelongsTo',
             'entity' => 'accountDetails.user',
             'model' => 'Backpack\CRUD\Tests\Unit\Models\User',
+            'attribute' => 'name',
         ],
     ];
 
@@ -278,6 +280,7 @@ class CrudPanelColumnsTest extends BaseDBCrudPanelTest
             'searchLogic' => false,
             'priority'    => 0,
             'relation_type' => 'BelongsTo',
+            'attribute' => 'content',
         ],
         'ac_article_content' => [
             'name'        => 'accountDetails.article',