Merge branch 'master' of https://github.com/Laravel-Backpack/CRUD

Author: tabacitu

src/resources/views/base/inc/footer.blade.php

@@ -1,10 +1,10 @@
 @if (config('backpack.base.show_powered_by') || config('backpack.base.developer_link'))
     <div class="text-muted ml-auto mr-auto">
       @if (config('backpack.base.developer_link') && config('backpack.base.developer_name'))
-      {{ trans('backpack::base.handcrafted_by') }} <a target="_blank" href="{{ config('backpack.base.developer_link') }}">{{ config('backpack.base.developer_name') }}</a>.
+      {{ trans('backpack::base.handcrafted_by') }} <a target="_blank" rel="noopener" href="{{ config('backpack.base.developer_link') }}">{{ config('backpack.base.developer_name') }}</a>.
       @endif
       @if (config('backpack.base.show_powered_by'))
-      {{ trans('backpack::base.powered_by') }} <a target="_blank" href="http://backpackforlaravel.com?ref=panel_footer_link">Backpack for Laravel</a>.
+      {{ trans('backpack::base.powered_by') }} <a target="_blank" rel="noopener" href="http://backpackforlaravel.com?ref=panel_footer_link">Backpack for Laravel</a>.
       @endif
     </div>
 @endif

src/resources/views/base/inc/main_header.blade.php

@@ -1,12 +1,12 @@
 <header class="{{ config('backpack.base.header_class') }}">
   <!-- Logo -->
-  <button class="navbar-toggler sidebar-toggler d-lg-none mr-auto ml-3" type="button" data-toggle="sidebar-show">
+  <button class="navbar-toggler sidebar-toggler d-lg-none mr-auto ml-3" type="button" data-toggle="sidebar-show" aria-label="{{ trans('backpack::base.toggle_navigation')}}">
     <span class="navbar-toggler-icon"></span>
   </button>
-  <a class="navbar-brand" href="{{ url(config('backpack.base.home_link')) }}">
+  <a class="navbar-brand" href="{{ url(config('backpack.base.home_link')) }}" title="{{ config('backpack.base.project_name') }}">
     {!! config('backpack.base.project_logo') !!}
   </a>
-  <button class="navbar-toggler sidebar-toggler d-md-down-none" type="button" data-toggle="sidebar-lg-show">
+  <button class="navbar-toggler sidebar-toggler d-md-down-none" type="button" data-toggle="sidebar-lg-show" aria-label="{{ trans('backpack::base.toggle_navigation')}}">
     <span class="navbar-toggler-icon"></span>
   </button>
 

src/resources/views/crud/fields/select2_multiple.blade.php

@@ -1,11 +1,16 @@
 <!-- select2 multiple -->
 @php
     if (!isset($field['options'])) {
-        $options = $field['model']::all();
+        $field['options'] = $field['model']::all();
     } else {
-        $options = call_user_func($field['options'], $field['model']::query());
+        $field['options'] = call_user_func($field['options'], $field['model']::query());
     }
-    $multiple = isset($field['multiple']) && $field['multiple']===false ? '': 'multiple';
+
+    //build option keys array to use with Select All in javascript.
+    $model_instance = new $field['model'];
+    $options_ids_array = $field['options']->pluck($model_instance->getKeyName())->toArray();
+
+    $field['multiple'] = $field['multiple'] ?? true;
 @endphp
 
 @include('crud::fields.inc.wrapper_start')
@@ -16,15 +21,16 @@
         style="width: 100%"
         data-init-function="bpFieldInitSelect2MultipleElement"
         data-select-all="{{ var_export($field['select_all'] ?? false)}}"
+        data-options-for-js="{{json_encode(array_values($options_ids_array))}}"
         @include('crud::fields.inc.attributes', ['default_class' =>  'form-control select2_multiple'])
-        {{$multiple}}>
+        {{ $field['multiple'] ? 'multiple' : '' }}>
 
         @if (isset($field['allows_null']) && $field['allows_null']==true)
             <option value="">-</option>
         @endif
 
         @if (isset($field['model']))
-            @foreach ($options as $option)
+            @foreach ($field['options'] as $option)
                 @if( (old(square_brackets_to_dots($field["name"])) && in_array($option->getKey(), old($field["name"]))) || (is_null(old(square_brackets_to_dots($field["name"]))) && isset($field['value']) && in_array($option->getKey(), $field['value']->pluck($option->getKeyName(), $option->getKeyName())->toArray())))
                     <option value="{{ $option->getKey() }}" selected>{{ $option->{$field['attribute']} }}</option>
                 @else
@@ -72,19 +78,14 @@
             function bpFieldInitSelect2MultipleElement(element) {
 
                 var $select_all = element.attr('data-select-all');
-
                 if (!element.hasClass("select2-hidden-accessible"))
                     {
                         var $obj = element.select2({
                             theme: "bootstrap"
                         });
 
-                        var options = [];
-                        @if (count($options))
-                            @foreach ($options as $option)
-                                options.push('{{ $option->getKey() }}');
-                            @endforeach
-                        @endif
+                        //get options ids stored in the field.
+                        var options = JSON.parse(element.attr('data-options-for-js'));
 
                         if($select_all) {
                             element.parent().find('.clear').on("click", function () {