Apply suggestions from code review

Author: tabacitu

src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php

@@ -193,8 +193,8 @@ protected function makeSureColumnHasEntity($column)
             // if the first part of the string exists as method in the model
             if (method_exists($this->model, $possibleMethodName)) {
 
-                // check model method for possibility of beeing a relationship
-                $column['entity'] = $this->checkMethodPropertiesForRelationship($this->model, $possibleMethodName) ? $column['name'] : false;
+                // check model method for possibility of being a relationship
+                $column['entity'] = $this->modelMethodIsRelationship($this->model, $possibleMethodName) ? $column['name'] : false;
 
                 if ($column['entity']) {
                     $parts = explode('.', $column['entity']);
@@ -226,8 +226,8 @@ protected function makeSureColumnHasEntity($column)
         // if there's a method on the model with this name
         if (method_exists($this->model, $column['name'])) {
 
-             // check model method for possibility of beeing a relationship
-            $column['entity'] = $this->checkMethodPropertiesForRelationship($this->model, $column['name']);
+             // check model method for possibility of being a relationship
+            $column['entity'] = $this->modelMethodIsRelationship($this->model, $column['name']);
 
             return $column;
         }
@@ -238,8 +238,8 @@ protected function makeSureColumnHasEntity($column)
             $possibleMethodName = Str::replaceLast('_id', '', $column['name']);
 
             if (method_exists($this->model, $possibleMethodName)) {
-                // check model method for possibility of beeing a relationship
-                $column['entity'] = $this->checkMethodPropertiesForRelationship($this->model, $possibleMethodName);
+                // check model method for possibility of being a relationship
+                $column['entity'] = $this->modelMethodIsRelationship($this->model, $possibleMethodName);
 
                 return $column;
             }

src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php

@@ -142,16 +142,16 @@ protected function makeSureFieldHasEntity($field)
         //if the name is dot notation we are sure it's a relationship
         if (strpos($field['name'], '.') !== false) {
             $possibleMethodName = Str::of($field['name'])->before('.');
-            // check model method for possibility of beeing a relationship
-            $field['entity'] = $this->checkMethodPropertiesForRelationship($model, $possibleMethodName) ? $field['name'] : false;
+            // check model method for possibility of being a relationship
+            $field['entity'] = $this->modelMethodIsRelationship($model, $possibleMethodName) ? $field['name'] : false;
 
             return $field;
         }
 
         // if there's a method on the model with this name
         if (method_exists($model, $field['name'])) {
-            // check model method for possibility of beeing a relationship
-            $field['entity'] = $this->checkMethodPropertiesForRelationship($model, $field['name']);
+            // check model method for possibility of being a relationship
+            $field['entity'] = $this->modelMethodIsRelationship($model, $field['name']);
 
             return $field;
         }
@@ -162,8 +162,8 @@ protected function makeSureFieldHasEntity($field)
             $possibleMethodName = Str::replaceLast('_id', '', $field['name']);
 
             if (method_exists($model, $possibleMethodName)) {
-                // check model method for possibility of beeing a relationship
-                $field['entity'] = $this->checkMethodPropertiesForRelationship($model, $possibleMethodName);
+                // check model method for possibility of being a relationship
+                $field['entity'] = $this->modelMethodIsRelationship($model, $possibleMethodName);
 
                 return $field;
             }

src/app/Library/CrudPanel/Traits/Relationships.php

@@ -324,7 +324,7 @@ private static function getPivotFieldStructure($field)
      * @param $method
      * @return bool|string
      */
-    private function checkMethodPropertiesForRelationship($model, $method)
+    private function modelMethodIsRelationship($model, $method)
     {
         $methodReflection = new \ReflectionMethod($model, $method);