Merge pull request #4556 from Laravel-Backpack/fix-bulk-actions

clear selections not found in filtered results

Author: tabacitu

src/resources/views/crud/columns/inc/bulk_actions_checkbox.blade.php

@@ -20,7 +20,7 @@ function addOrRemoveCrudCheckedItem(element) {
                 let primaryKeyValue = checkbox.dataset.primaryKeyValue;
 
                 crud.checkedItems ??= [];
-
+                
                 if (checked) {
                     // add item to crud.checkedItems variable
                     crud.checkedItems.push(primaryKeyValue);
@@ -56,9 +56,34 @@ function addOrRemoveCrudCheckedItem(element) {
 
     if (typeof markCheckboxAsCheckedIfPreviouslySelected !== 'function') {
         function markCheckboxAsCheckedIfPreviouslySelected() {
+            let checkedItems = crud.checkedItems ?? [];
+            let pageChanged = localStorage.getItem('page_changed') ?? false;
+            let tableUrl = crud.table.ajax.url();
+            let hasFilterApplied = false;
+
+            if (tableUrl.indexOf('?') > -1) {
+                if (tableUrl.substring(tableUrl.indexOf('?') + 1).length > 0) {
+                    hasFilterApplied = true;
+                }
+            }
+
+            // if it was not a page change, we check if datatables have any search, or the url have any parameters.
+            // if you have filtered entries, and then remove the filters we are sure the entries are in the table.
+            // we don't remove them in that case.
+            if (! pageChanged && (crud.table.search().length !== 0 || hasFilterApplied)) {
+                crud.checkedItems = [];
+            }
             document
                 .querySelectorAll('input.crud_bulk_actions_line_checkbox[data-primary-key-value]')
-                .forEach(elem => elem.checked = crud.checkedItems?.length && crud.checkedItems.indexOf(elem.dataset.primaryKeyValue) > -1);
+                .forEach(function(elem) {
+                    let checked = checkedItems.length && checkedItems.indexOf(elem.dataset.primaryKeyValue) > -1;
+                    elem.checked = checked;
+                    if (checked && crud.checkedItems.indexOf(elem.dataset.primaryKeyValue) === -1) {
+                        crud.checkedItems.push(elem.dataset.primaryKeyValue);
+                    }
+                });
+            
+            localStorage.removeItem('page_changed');
         }
     }
 

src/resources/views/crud/inc/datatables_logic.blade.php

@@ -333,14 +333,19 @@ functionsToRunOnDataTablesDrawEvent: [],
             localStorage.setItem('DataTables_crudTable_/{{$crud->getRoute()}}_pageLength', len);
         });
 
-      // make sure AJAX requests include XSRF token
-      $.ajaxPrefilter(function(options, originalOptions, xhr) {
-          var token = $('meta[name="csrf_token"]').attr('content');
+        // make sure AJAX requests include XSRF token
+        $.ajaxPrefilter(function(options, originalOptions, xhr) {
+            var token = $('meta[name="csrf_token"]').attr('content');
 
-          if (token) {
+            if (token) {
                 return xhr.setRequestHeader('X-XSRF-TOKEN', token);
-          }
-      });
+            }
+        });
+
+
+        $('#crudTable').on( 'page.dt', function () {
+            localStorage.setItem('page_changed', true);
+        });
 
       // on DataTable draw event run all functions in the queue
       // (eg. delete and details_row buttons add functions to this queue)