Merge pull request #4315 from Laravel-Backpack/add-better-error-message

mention pro when view not found for fields as a suggestion

Author: tabacitu

src/app/Exceptions/BackpackProRequiredException.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Backpack\CRUD\app\Exceptions;
+
+class BackpackProRequiredException extends \Exception
+{
+    /**
+     * Render the exception into an HTTP response.
+     *
+     * @param  \Illuminate\Http\Request
+     * @return \Illuminate\Http\Response
+     */
+    public function render($request)
+    {
+        // 0, by default, pass only what is a feature we construct the rest of the message
+        // 1 use the provided message in full
+        switch ($this->getCode()) {
+            case 0:
+                $this->message = $this->message.' is a Backpack PRO feature. Please purchase and install the Backpack\PRO addon from backpackforlaravel.com';
+                break;
+        }
+
+        return response(view('errors.500', ['exception' => $this]), 500);
+    }
+}

src/app/Http/Controllers/ChartController.php

@@ -2,6 +2,8 @@
 
 namespace Backpack\CRUD\app\Http\Controllers;
 
-class ChartController extends \Backpack\Pro\Http\Controllers\ChartController
-{
+if (backpack_pro()) {
+    class ChartController extends \Backpack\Pro\Http\Controllers\ChartController
+    {
+    }
 }

src/app/Http/Controllers/CrudController.php

@@ -34,6 +34,7 @@ public function __construct()
         // the complete request inside the CrudPanel object.
         $this->middleware(function ($request, $next) {
             $this->crud = app()->make('crud');
+
             $this->crud->setRequest($request);
 
             $this->setupDefaults();

src/app/Http/Controllers/Operations/BulkCloneOperation.php

@@ -2,7 +2,19 @@
 
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
 
-trait BulkCloneOperation
-{
-    use \Backpack\Pro\Http\Controllers\Operations\BulkCloneOperation;
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
+
+if (! backpack_pro()) {
+    trait BulkCloneOperation
+    {
+        public function setupBulkCloneOperationDefaults()
+        {
+            throw new BackpackProRequiredException('BulkCloneOperation');
+        }
+    }
+} else {
+    trait BulkCloneOperation
+    {
+        use \Backpack\Pro\Http\Controllers\Operations\BulkCloneOperation;
+    }
 }

src/app/Http/Controllers/Operations/BulkDeleteOperation.php

@@ -2,7 +2,19 @@
 
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
 
-trait BulkDeleteOperation
-{
-    use \Backpack\Pro\Http\Controllers\Operations\BulkDeleteOperation;
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
+
+if (! backpack_pro()) {
+    trait BulkDeleteOperation
+    {
+        public function setupBulkDeleteOperationDefaults()
+        {
+            throw new BackpackProRequiredException('BulkDeleteOperation');
+        }
+    }
+} else {
+    trait BulkDeleteOperation
+    {
+        use \Backpack\Pro\Http\Controllers\Operations\BulkDeleteOperation;
+    }
 }

src/app/Http/Controllers/Operations/CloneOperation.php

@@ -2,7 +2,19 @@
 
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
 
-trait CloneOperation
-{
-    use \Backpack\Pro\Http\Controllers\Operations\CloneOperation;
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
+
+if (! backpack_pro()) {
+    trait CloneOperation
+    {
+        public function setupCloneOperationDefaults()
+        {
+            throw new BackpackProRequiredException('CloneOperation');
+        }
+    }
+} else {
+    trait CloneOperation
+    {
+        use \Backpack\Pro\Http\Controllers\Operations\CloneOperation;
+    }
 }

src/app/Http/Controllers/Operations/FetchOperation.php

@@ -2,7 +2,19 @@
 
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
 
-trait FetchOperation
-{
-    use \Backpack\Pro\Http\Controllers\Operations\FetchOperation;
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
+
+if (! backpack_pro()) {
+    trait FetchOperation
+    {
+        public function setupFetchOperationDefaults()
+        {
+            throw new BackpackProRequiredException('FetchOperation');
+        }
+    }
+} else {
+    trait FetchOperation
+    {
+        use \Backpack\Pro\Http\Controllers\Operations\FetchOperation;
+    }
 }

src/app/Http/Controllers/Operations/InlineCreateOperation.php

@@ -2,7 +2,19 @@
 
 namespace Backpack\CRUD\app\Http\Controllers\Operations;
 
-trait InlineCreateOperation
-{
-    use \Backpack\Pro\Http\Controllers\Operations\InlineCreateOperation;
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
+
+if (! backpack_pro()) {
+    trait InlineCreateOperation
+    {
+        public function setupInlineCreateOperationDefaults()
+        {
+            throw new BackpackProRequiredException('InlineCreateOperation');
+        }
+    }
+} else {
+    trait InlineCreateOperation
+    {
+        use \Backpack\Pro\Http\Controllers\Operations\InlineCreateOperation;
+    }
 }

src/app/Library/CrudPanel/CrudFilter.php

@@ -2,6 +2,7 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel;
 
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
 use Closure;
 use Illuminate\Support\Str;
 use Symfony\Component\HttpFoundation\ParameterBag;
@@ -25,7 +26,7 @@ class CrudFilter
     public function __construct($options, $values, $logic, $fallbackLogic)
     {
         if (! backpack_pro()) {
-            abort(500, 'Backpack filters are a PRO feature. Please purchase and install <a href="https://backpackforlaravel.com/pricing">Backpack\PRO</a>.');
+            throw new BackpackProRequiredException('Filter');
         }
 
         // if filter exists

src/app/Library/CrudPanel/Traits/Read.php

@@ -2,6 +2,7 @@
 
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
 
+use Backpack\CRUD\app\Exceptions\BackpackProRequiredException;
 use Exception;
 
 /**
@@ -129,7 +130,7 @@ public function getEntries()
     public function enableDetailsRow()
     {
         if (! backpack_pro()) {
-            abort(500, 'Details row is a PRO feature. Please purchase and install <a href="https://backpackforlaravel.com/pricing">Backpack\PRO</a>.');
+            throw new BackpackProRequiredException('Details row');
         }
 
         $this->setOperationSetting('detailsRow', true);
@@ -316,7 +317,7 @@ private function abortIfInvalidPageLength($value)
     public function enableExportButtons()
     {
         if (! backpack_pro()) {
-            abort(500, 'Export buttons are a PRO feature. Please purchase and install <a href="https://backpackforlaravel.com/pricing">Backpack\PRO</a>.');
+            throw new BackpackProRequiredException('Export buttons');
         }
 
         $this->setOperationSetting('exportButtons', true);