Skip to content

Commit f4dad20

Browse files
authored
Merge pull request #4528 from basselhossam/patch-1
[bug] fix when ConvertEmptyStringsToNull is disabled for M-M relations
2 parents d015494 + 2dadcfc commit f4dad20

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/app/Library/CrudPanel/Traits/Create.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,11 @@ private function createRelationsForItem($item, $formattedRelations)
121121
case 'MorphToMany':
122122
$values = $relationDetails['values'][$relationMethod] ?? [];
123123
$values = is_string($values) ? json_decode($values, true) : $values;
124+
125+
// disabling ConvertEmptyStringsToNull middleware may return null from json_decode() if an empty string is used.
126+
// we need to make sure no null value can go foward so we reassure that values is not null after json_decode()
127+
$values = $values ?? [];
128+
124129
$relationValues = [];
125130

126131
if (is_array($values) && is_multidimensional_array($values)) {

0 commit comments

Comments
 (0)