Skip to content

Commit fcd41b7

Browse files
authored
Merge pull request #4820 from Laravel-Backpack/fix-fluent-column-key
[Bug] Can't change column key fluently
2 parents 19cd3ab + 7aa627c commit fcd41b7

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/app/Library/CrudPanel/CrudColumn.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public function key(string $key)
8989
$column['key'] = $key;
9090
}
9191
$this->attributes = $column;
92-
$this->setOperationSetting('columns', array_merge($columns, [$key => $column]));
92+
$this->crud()->setOperationSetting('columns', array_merge($columns, [$key => $column]));
9393

9494
return $this;
9595
}

tests/Unit/CrudPanel/CrudPanelColumnsTest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,17 @@ public function testOrderColumnsMixedList()
536536
$this->assertEquals(['column2', 'column1', 'column3'], array_keys($this->crudPanel->columns()));
537537
}
538538

539+
public function testItCanChangeTheColumnKey()
540+
{
541+
$this->crudPanel->column('test');
542+
543+
$this->assertEquals('test', $this->crudPanel->columns()['test']['key']);
544+
545+
$this->crudPanel->column('test')->key('new_key');
546+
547+
$this->assertEquals('new_key', $this->crudPanel->columns()['new_key']['key']);
548+
}
549+
539550
public function testItCanAddAFluentColumn()
540551
{
541552
$this->crudPanel->setModel(User::class);

0 commit comments

Comments
 (0)