Skip to content

Conversation

@sashaphmn
Copy link

WHY

BEFORE - What was wrong? What was happening before this PR?

??

AFTER - What is happening after this PR?

??

HOW

How did you achieve that, in technical terms?

??

Is it a breaking change or non-breaking change?

??

How can we test the before & after?

??

@welcome
Copy link

welcome bot commented Mar 5, 2025

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@jcastroa87
Copy link
Member

Hello @sashaphmn thanks for this PR, I updated to "img.shields.io" so we will check and merge if everything is ok.

Thanks again.

Cheers.

@jcastroa87 jcastroa87 requested review from pxpm and tabacitu March 5, 2025 17:17
@jcastroa87 jcastroa87 moved this to Ready to Merge in This week Mar 5, 2025
@sashaphmn
Copy link
Author

Hello @jcastroa87 always happy to help

@sashaphmn
Copy link
Author

Hey. decided to make the changes a little differently, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Merge

Development

Successfully merging this pull request may close these issues.

4 participants