saveMinorUpdateFormValidation custom validation message is not working

[blessen131]

I am trying to add custom validation for the editable column, but I am getting error message as 'The given data was invalid`
public function saveMinorUpdateFormValidation()
{
if (request('attribute') === 'completed' && request('value') !== 0) {
throw ValidationException::withMessages([
'completed' => ['Cannot revert the status'],
]);
}
}

"backpack/crud": "^5.6",
"backpack/editable-columns": "^2.1"

[backpack-ai-bot[bot]]

Based on the information provided in the knowledge sources, it appears that there was indeed an issue with custom validation messages in the saveMinorUpdateFormValidation method for editable columns in earlier versions of Backpack. However, this issue has been addressed in a recent update.

According to the Editable Columns Changelog, version 3.0.6 (released on 20-Feb-2024) added support for custom validation messages:

## 3.0.6 20-Feb-2024
- [BugFix] Adds support for Custom validation messages ([@karandatwani92](https://github.com/karandatwani92))

However, I notice that you're using an older version of both Backpack CRUD (5.6) and Editable Columns (2.1). The fix for custom validation messages is available in version 3.0.6 and later of the Editable Columns package.

To resolve this issue, I recommend updating your Backpack packages to the latest versions. You can do this by running:

composer update backpack/crud backpack/editable-columns

After updating, make sure your composer.json file includes the latest versions:

"backpack/crud": "^6.x",
"backpack/editable-columns": "^3.0.6"

If you're unable to update to the latest versions due to project constraints, you might need to implement a workaround. One possible approach is to override the saveMinorUpdate method in your controller, as suggested in this community forum discussion:

public function saveMinorUpdate()
{
    // Validate request
    $this->saveMinorUpdateFormValidation();

    // Update entry
    $saved = $this->saveMinorUpdateEntry();

    return [
        'saved' => $saved,
        'row' => $this->getMinorUpdateRow(),
    ];
}

By overriding this method, you might have more control over how the validation errors are handled and returned.

Remember to test thoroughly after making these changes to ensure everything works as expected in your specific setup.

ℹ️ Please note our AI Bot does not reply to follow-ups, this will be the only AI answer in this thread. If the AI helped you find the answer, please mark it as answered or write details below so it can learn. Then close the conversation. If not, please give more information for when a human reads this. ℹ️

Relevant sources:

Github Issue (closed): [Editable Columns] [Bug] [Minor improvement] Empty custom messages
Editable Columns|Usage Part 2
Editable Columns|Usage Part 2
Editable Columns|Editable Columns
Github Issue (closed): [Bug] Editable columns update error
Override update function on editable_select
Editable Columns|1.0.12 10-May-2022
Github Issue (closed): How should I be using the messages() method in EntityRequest?

[karandatwani92]

Hey @blessen131

The correct code would be:

// Assuming the column name is "status"
public function saveMinorUpdateFormValidation()
    {
        if (request('attribute') === 'status' && $this->minorUpdateEntry->status === 'completed') { // if $entry->status already "completed"
            throw ValidationException::withMessages([
                'status' => ['Cannot revert the status'],
            ]);
        }
    }

[blessen131]

still not getting the custom message I am following the https://backpackforlaravel.com/products/editable-columns docs
public function saveMinorUpdateFormValidation()
{
// validation example for the "price"
// note that this is just an example, you may do this with the FormRequest
if (request('attribute') === 'price' && !is_numeric(request('value'))) {
throw ValidationException::withMessages([
'price' => ['The price has to be a number.'],
]);
}
}
Also I am getting error Undefined property: $minorUpdateEntry
"backpack/crud": "^5.6",
"backpack/editable-columns": "^2.1"

[karandatwani92]

Hey @blessen131

Your code is working for me.

Screen.Recording.2025-02-05.at.2.20.40.PM.mov

But I'm testing it on the latest version; Try "backpack/editable-columns": "^3.0", and composer update

[blessen131]

Could you please provide an example for the editable switch?
If the value is true cannot revert the option back to false

Or Can I add alert inside that?

if (request('attribute') === 'price' && !is_numeric(request('value'))) {
          Alert::error('The price has to be a number ')->flash();
          throw ValidationException::withMessages([
                'price' => ['The price has to be a number.'],
          ]);
}