Issue with Nested CRUD & setAccessCondition

[pakoArtal]

Hello,
I encountered a problem using setAccessCondition and a Nested CRUD (e.g.: user's posts) like in the tutorial https://backpackforlaravel.com/articles/tutorials/how-to-setup-nested-crud, AND setAccessCondition

With Nested Crud I have:

admin/user/{user_id}/post/{post_id}/show
admin/user/{user_id}/post/create

protected function setupCreateOperation()
    {
        CRUD::setAccessCondition(['create'], function ($entry) {
            return (backpack_user()->hasRole('User') || backpack_user()->hasRole('Admin')) ? true : false;
        });

setAccessCondition calls getCurrentEntryId() in vendor/backpack/crud/src/app/Library/CrudPanel/Traits/Read.php

public function getCurrentEntryId()
    {
        if ($this->entry) {
            return $this->entry->getKey();
        }

        $params = Route::current()?->parameters() ?? [];

        return  // use the entity name to get the current entry
                // this makes sure the ID is current even for nested resources
                $this->getRequest()->input($this->entity_name) ??
                // otherwise use the next to last parameter
                array_values($params)[count($params) - 1] ??
                // otherwise return false
                false;
    }

When creating, there is no current entry so it tries to find the post_id parameter (array_values($params)[count($params) - 1] ) but wrongly gets the user_id

My solution is to add and extra check.

public function getCurrentEntryId()
    {
        if ($this->entry) {
            return $this->entry->getKey();
        }

        **// when creating, there is no current entry
        if ($this->getOperation() === 'create') {
            return false;
        }**

        $params = Route::current()?->parameters() ?? [];

        return  // use the entity name to get the current entry
                // this makes sure the ID is current even for nested resources
                $this->getRequest()->input($this->entity_name) ??
                // otherwise use the next to last parameter
                array_values($params)[count($params) - 1] ??
                // otherwise return false
                false;
    }

Is there a better way?
How can I override getCurrentEntryId?

[backpack-ai-bot[bot]]

You're correct in identifying that Backpack's getCurrentEntryId() can return the wrong parameter (e.g., user_id instead of post_id) in nested CRUD scenarios, especially during create operations where no entry exists yet. This is a known issue and has been discussed and worked around by the community in several places.

The Problem

When using setAccessCondition (or similar logic that relies on getCurrentEntryId()), Backpack tries to determine the current entry's ID from the route parameters. In nested resources, the last parameter may not always be the correct entity's ID—during create, it might be user_id instead of post_id, leading to incorrect behavior or errors.

Community Workarounds

Several workarounds have been suggested and used:

• Trait-based override: Some users implement a trait in their controllers to override methods like edit, destroy, etc., to always fetch the correct parameter (e.g., the last parameter in the route) for the child entity. Example:

  public function getLastParameter()
  {
      $params = \Route::current()->parameters();
      return array_values($params)[count($params)-1];
  }
  
  public function edit($id)
  {
      return parent::edit($this->getLastParameter());
  }
  // ...repeat for other operations as needed

  Nested routes and resources workaround

• Manual parameter handling in setup(): In your controller's setup method, you can fetch the correct parameter using Route::current()->parameter('post') or similar, and use that for your logic.

• Check for operation type: As you suggested, adding a check for the operation type (e.g., if ($this->getOperation() === 'create')) before trying to fetch an entry ID is a valid workaround. This prevents getCurrentEntryId() from returning an incorrect value during create operations.

Official Patch and PRs

There is an official PR (Get the correct current ID for nested resources) that aims to address this by improving how the current entry ID is determined for nested resources. However, the underlying challenge remains: Backpack must guess which parameter is the actual entity ID, and this can be ambiguous in complex nested routes.

Overriding getCurrentEntryId

If you want to override getCurrentEntryId, you can do so by extending the CrudPanel or by using a trait in your CrudController. For example:

// In your CrudController
public function getCurrentEntryId()
{
    if ($this->entry) {
        return $this->entry->getKey();
    }
    if ($this->getOperation() === 'create') {
        return null; // or false, depending on your needs
    }
    $params = \Route::current()?->parameters() ?? [];
    // Your custom logic here
    return $this->getRequest()->input($this->entity_name) ??
           array_values($params)[count($params) - 1] ??
           null;
}

You can also use a trait to share this logic across multiple controllers if needed.

Summary

• Your approach (checking for the create operation) is a valid and common workaround.
• Overriding getCurrentEntryId in your controller or via a trait is the recommended way to customize this behavior until Backpack provides a more robust solution.
• Always ensure your override returns null (not false) when no entry is present, as recent PRs have moved in this direction for better null coalescing support fix: getCurrentEntryId() should return null instead of false.

If you need to apply this fix project-wide, a trait is the cleanest approach. If you only need it in one controller, override the method directly there.

Let me know if you need a more specific code example for your use case!

ℹ️ Please note our AI Bot does not reply to follow-ups, this will be the only AI answer in this thread. If the AI helped you find the answer, please mark it as answered or write details below so it can learn. Then close the conversation. If not, please give more information for when a human reads this. ℹ️

Relevant sources:

Github Issue (closed): Previous CrudController edit method functionality is now broken
Github Issue (closed): Show operation addClause ignoring for SoftDeletes
Adding fixed value to create and update
Github Issue (closed): [Bug] setAccessCondition()causing error on create operations
Github Issue (closed): Nested resources problem
[Feature] Custom access closures
Github Issue (closed): Allow developers to get the current crud entry based on route parameter
Github Issue (closed): Issue with Controller inheritance / nested resources
Github Issue (closed): Nested routes and resources
[Ready] Get the correct current ID for nested resources
fix: getCurrentEntryId() should return null instead of false