-
Notifications
You must be signed in to change notification settings - Fork 168
Open
Labels
Description
TODOs to launch Backpack V7
BEFORE we merge DataFormModal
- π΄ New in v7 page - if in the
config/backpack/operations/update.phpI setupdateButtonWithModalFormtotrue, then I get a big fat error on the New in v7 page: https://flareapp.io/share/A7EZ9GL5 - π΄ With
createButtonWithModalFormandupdateButtonWithModalFormset totrue, in Skills, I go to edit the first entry; the modal appears and I only change the title; i refresh the page and i notice this did NOT change the existing entry - it created a new one; see demo here - https://share.cleanshot.com/yzhzstKj - π΄ With
createButtonWithModalFormandupdateButtonWithModalFormset totrue, I go to Users and click to add a user; the modal appears but i can't see the form inputs, I see a validation error - Error loading form. Please try again. There's an error 500 in the browser console log; Edit button (in a modal) doesn't work either; - π΄ Cannot test the DataFormModal on Article, because there are JS errors - https://share.cleanshot.com/QRkJwQTH - due to the Browse field which uses colorbox. The error is - "Failed to find a valid digest in the 'integrity' attribute for resource 'http://bp-v7-beta.test/storage/basset/cdn.jsdelivr.net/npm/[email protected]/jquery.colorbox.min.js' with computed SHA-384 integrity 'XUlOVE421mbJIf+wLZXpJXboiFVAkIkvwE9XKUq07omO7eiBgPElhHBFYHJ9QoyN'. The resource has been blocked."
- π΄ Cannot test the DataFormModal on Monster, because there are JS errors - https://share.cleanshot.com/f5Gcsk3q - so all the js-based fields (like select2) stop working
- π΄ Not all inline comments in this PR are resolved - DataFormModal componentΒ CRUD#5863
AFTER we merge DataFormModal
- π΄ I'm in /admin/article/1031/show and it's using the new
bp-datagrid; this would probably be a good default for NEW projects, but not for projects that are UPGRADING; so let's add an upgrade guide step, to tell the people to place the proper config so they keep the old functionality by default; - π΄ regarding the form components - do they re-use the same save actions or do you have to create a new saveaction? is that easy to do? i would expect that everywhere you use a form component you'll kind of need to customize the saveaction, to redirect somewhere else or trigger notification bubble or something, so we have to make it easy;
- π΄ New in v7 page - sometimes when scrolling on this page, when the cursor is on top of the datatable, the page doesn't really scroll down, it "jumps" up and down a few pixels, and no matter how much i scroll it doesn't go down; i think it's because of the fixed-table-header thing in datatable;
- π‘ I'm testing New in V7 > Quick Add Tag; form works, but i get sent to dashboard afterwards; not intuitive; it should probably redirect to the Tag list page, so you can see the tag you created; alternatively, redirect back to the same page (scrollto #quick-add-tag section) with a bubble notification that it was added;
- π‘ I'm testing New in V7 > Quick Edit Tag; form works, but i can't easily tell that it worked, because after form submission i am sent to the dashboard; why the dashboard?! would be better i get redirected back to the same page, to #quick-edit-tag;
- π΅ I'm testing New in V7 > Create Invoice; the select2 field for the owner, when you open the dropdown, has a blue border around the dropdown but no blue border on the field itself; that's weird to be; it should probably not have a blue border at all, but the same border the select has (light grey or smth);
- π΅ I'm testing New in V7 > Create Invoice; the select2 field for the owner has blue highlight instead of purple (the default color right now); why?
- π‘ I'm testing New in V7 > Create Invoice; the select2 field is using InlineCreate, but the Add button is blue instead of purple; why?
- π‘ I'm testing New in V7 > Create Invoice; i use the incline-create functionality and when the modal opens, it looks OK but it would look MUCH better if inside the
formelement, the firstdivdid NOT have the.cardclass; - π‘ elfinder looks pretty bad, it's like it's 1995 over here; and why is it always on "dark mode"?
- I'm testing New in V7; the components that add a form (Quick Add Tag, Quick Edit Tag) all have
card-body bg-lightand this messes up the bottom rounded corners - they are no longer visible so the card looks off; fixed indataform-examples.blade.phpby removingbg-light; additionally we should pass a parameter to the form so that the fields aren't wrapped in a.cardand subsequent.card-bodyat all (same as above); - π‘ I'm testing New in V7 > Quick Add Tag; I've submitted it empty, but then there's a whole page refresh, then scroll to the form with errors; I... kind of expected it to submit with JS; maybe Livewire broke my expectations; but now I'm thinking... we already added a way to return the content of the form (for the modal form)... soo... can't we make the FormComponent work with AJAX now... so it doesn't do a page refresh at all, on validation? this would be a HUGE change, won't it? but it would make it much more useful than the current component, right? or maybe we should create a NEW component,
DataFormAjaxthat does that? - π‘ I'm testing New in V7 > Quick Add Invoice in a Modal; it's weird that the form is inside a
card; let's have a way to tell the component to not echo that.cardand.card-bodyclass; perhaps something likecard_wrapper => false? that makes all form modals look INSTANTLY better; same with regular form components - they look better without the card too; i would even argue that this should be FALSE by default, and it's only set as TRUE on the Create and Update operations, where the form component needs the card because it's solo on that page, directly on the background; - I'm testing New in V7 > Quick Edit Invoice in a Modal; worked EXACTLY as i expected; great job here! I LOVE IT!
- π‘ I'm testing New in V7 > Quick Add Invoice in a Modal; while i'm in a form, I clicked "Ctrl+S" to trigger the same of that form... but what was triggered was a form OUTSIDE the modal, the CreateInvoice form; would it be easy to adapt the Ctrl+S javascript to submit the form where you have a input selected (or cursor, smth)?
- π‘ I'm testing New in V7 > Edit Skill, on the modal-form branches of everything... and I don't see anything populated here; What entry am I editing? I don't remember if this was working as expected on the beta branch; but honestly I don't see why this component should be here - we're already demo-ing this functionality using Quick Edit Tag above;
- π‘ the homepage for the demo is too basic; this is a lost opportunity here - we can have the person select what they want the admin panel to look like (layout, colors etc) so that they know it doesn't HAVE TO look like the default; I'd go further than that, maybe this selection wizard should be MANDATORY; if they go through this wizard telling us what they like, that will make sure that we show a UI for Backpack they are most likely to enjoy;
- π΅ I'm on the dashboard playing around with various layouts - and i notice slight differences between the pages as i do so (eg. some missing padding between charts); this tells me that the demo is using a different dashboard page for each theme, and perhaps even for each layout - which OUCH, that's not DRY at all;
- π‘ I'm on the New in V7 page; none of the "See docs" button actually lead to the docs of that component;
- π‘ FileManager looks so ugly; and it has an ugly bottom padding too; makes us look so old;
- π΅ Addons > TranslationManager uses EditableColumn and the dotten lines seem a little too long;
- π΅ Addons > LogManager > Preview - each log item has rounded corners at the top, but not at the bottom and that makes it look a little weird; maybe
.card-headershould have.rounded-0? but that would affect all themes π - π‘ Themes Palette - I can't select the new backgrounds (pinstripes etc);
- π΅ Themes Palette - why no "RTL" selector? Maybe even in the homepage wizard we should have it, on the demo; this would probably make it INSTANTLY more appealing to everybody who wants an Arabic or Israeli admin panel;
- π‘ Demo Onboarding Wizard - come to think about it, why don't we also ask them to choose their language? Backpack itself supports A LOT of languages, so this would help tailor the demo to what they will be building;
- π‘ CRUD List operation - on dark mode, the datatable "flashes" a light color;
- π‘ CRUD List operation - spinner is grey, which will NOT be visible on a dark background; this is probably a good opportunity to replace the spinner from a GIF to a SVG one, using a color that can be customized using CSS only; that way the
tablertheme for example can just set it tovar(--tblr-primary)and we know it'll look good on any background, and stand out; - π‘ admin/editable-monster - i believe the editable columns had a green checkmark or spinner something, to show they are saving... but now there's no feedback on the fact that they're being saved;
- π‘ PetShop > Skill > Add Skill in modal - then after i added it, the list page doesn't refresh; and i see no notification bubble to know that it was successful; same with PetShop > Comments > Add Comment in modal;
- π‘ Monster > Add Monster in a modal - I think this shows that we need the modal component to have a parameter or something, to allow the developer to make the modal-xl sometimes;
BEFORE Launch
- upgrade BackpackForLaravel.com to v7, manually;
- check Demo
nextPR, to see what changed; add to upgrade guide; - create
php artisan backpack:upgradecommand; - upgrade POVTickets codebase to v7, using the upgrade command;
- implement new features in POVT codebase;
DURING Launch
- tag all repos (from addons to core);
- rename directory in docs (no more
-devsuffix); - make v7 docs the default;
- change v7 landing page to no longer say "coming soon" or "beta";
AFTER Launch
- write article about the launch;
- announce on Twitter;
Metadata
Metadata
Labels
Type
Projects
Status
In Progress
Status
In Progress