Difference between Laravel validation.php and Laravel Lang validation.php

[fabius85]

Description:

Looks like source/validation.php is outdated if compared to current 8.x Laravel resources/lang/en/validation.php
This difference is then reflected also on source/validation-inline.php

The following strings are different:
alpha, alpha_dash, alpha_num, gte [numeric, file, string], lte [numeric, file, string], max [numeric, file, string, array], multiple_of

The following strings are not present in the original Laravel validation.php:
attached, relatable

The following entire block at the end of the file is missing from Laravel Lang validation.php:

    /*
    |--------------------------------------------------------------------------
    | Custom Validation Attributes
    |--------------------------------------------------------------------------
    |
    | The following language lines are used to swap our attribute placeholder
    | with something more reader friendly such as "E-Mail Address" instead
    | of "email". This simply helps us make our message more expressive.
    |
    */

    'attributes' => [],

Is there any reason for not updating it to match original Laravel validation.php?

[caouecs]

Laravel 6/7

[fabius85]

Ok so removing the attached and relatable keys would break compatibility with previous Laravel versions.
But I think that updating the english validation strings with new ones from Laravel's validation.php shouldnt do any harm.
I mean, the array keys are the same, it's just the message that was slightly modified in a more proper english.
Example for gte.numeric:
old message > 'The :attribute must be greater than or equal :value.'
new message > 'The :attribute must be greater than or equal to :value.'

[andrey-helldar]

Ok so removing the attached and relatable keys would break compatibility with previous Laravel versions.

The attached and relatable keys are not used in Laravel 6, 7, 8 and 9:

• https://github.com/laravel/laravel/blob/6.x/resources/lang/en/validation.php
• https://github.com/laravel/laravel/blob/7.x/resources/lang/en/validation.php
• https://github.com/laravel/laravel/blob/8.x/resources/lang/en/validation.php
• https://github.com/laravel/laravel/blob/master/lang/en/validation.php

PR to remove these keys has already been created.

[andrey-helldar]

As for correcting the proposal forms to be more correct, you can create a PR.

[andrey-helldar]

The attached and relatable keys belong to Nova.

[andrey-helldar]

@caouecs, I created a Laravel-Lang/lang#1940 on splitting the main validation files from Nova.

[andrey-helldar]

@fabius85

The following entire block at the end of the file is missing from Laravel Lang validation.php:

That's right. Since we use two versions of translations, regular and inline, we decided to move the block with attribute names to an external file.

This will avoid duplication of data when using translation managers, since translation of attributes may be needed when using any of the files.