Renaming "optional" to "placeholder" Re: #60

Signed-off-by: Adam Engebretson <adam@enge.me>

Author: adamgoose

src/FormBuilder.php

@@ -494,10 +494,10 @@ public function select($name, $list = [], $selected = null, $options = [])
     // all together into one single HTML element that can be put on the form.
     $html = [];
 
-    if(isset($options['optional']))
+    if(isset($options['placeholder']))
     {
-      $html[] = $this->placeholderOption($options['optional'], $selected);
-      unset($options['optional']);
+      $html[] = $this->placeholderOption($options['placeholder'], $selected);
+      unset($options['placeholder']);
     }
 
     foreach($list as $value => $display)

tests/FormBuilderTest.php

@@ -320,15 +320,15 @@ public function testFormWithOptionalPlaceholder()
       'size',
       ['L' => 'Large', 'S' => 'Small'],
       null,
-      ['optional' => 'Select One...']
+      ['placeholder' => 'Select One...']
     );
     $this->assertEquals($select, '<select name="size"><option selected="selected">Select One...</option><option value="L">Large</option><option value="S">Small</option></select>');
 
     $select = $this->formBuilder->select(
       'size',
       ['L' => 'Large', 'S' => 'Small'],
       'L',
-      ['optional' => 'Select One...']
+      ['placeholder' => 'Select One...']
     );
     $this->assertEquals($select, '<select name="size"><option>Select One...</option><option value="L" selected="selected">Large</option><option value="S">Small</option></select>');
   }