Skip to content

Commit ec20546

Browse files
author
nejc
committed
Fix code style: remove superfluous PHPDoc, enforce new with parentheses, and other Pint fixes.
1 parent 0f37402 commit ec20546

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

src/BaseRepository.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@
1111

1212
/**
1313
* @template TModel of Model
14+
*
1415
* @implements RepositoryInterface<TModel>
1516
*/
1617
abstract class BaseRepository implements RepositoryInterface
1718
{
18-
/**
19-
* @var Model
20-
*/
2119
protected Model $model;
2220

2321
public function __construct(Model $model)
@@ -32,6 +30,7 @@ public function all(): Collection
3230
{
3331
/** @var Collection<int, TModel> $result */
3432
$result = $this->model->newQuery()->orderByDesc('id')->get();
33+
3534
return $result;
3635
}
3736

@@ -47,6 +46,7 @@ public function find(int|string $id): ?Model
4746
{
4847
/** @var TModel|null $result */
4948
$result = $this->model->newQuery()->find($id);
49+
5050
return $result;
5151
}
5252

@@ -57,6 +57,7 @@ public function findBy(string $field, mixed $value): ?Model
5757
{
5858
/** @var TModel|null $result */
5959
$result = $this->model->newQuery()->where($field, $value)->first();
60+
6061
return $result;
6162
}
6263

@@ -67,6 +68,7 @@ public function create(array $data): Model
6768
{
6869
/** @var TModel $result */
6970
$result = $this->model->newQuery()->create($data);
71+
7072
return $result;
7173
}
7274

tests/UserRepositoryTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
use Illuminate\Database\Capsule\Manager as Capsule;
6+
use Illuminate\Database\Eloquent\Model;
47
use Illuminate\Database\Schema\Blueprint;
58
use Prefabs\UserRepository;
6-
use Illuminate\Database\Eloquent\Model;
79

8-
describe('UserRepository', function () {
9-
beforeEach(function () {
10+
describe('UserRepository', function (): void {
11+
beforeEach(function (): void {
1012
// Setup Eloquent with in-memory SQLite
1113
$capsule = new Capsule();
1214
$capsule->addConnection([
@@ -18,7 +20,7 @@
1820
$capsule->bootEloquent();
1921

2022
// Create users table
21-
Capsule::schema()->create('users', function (Blueprint $table) {
23+
Capsule::schema()->create('users', function (Blueprint $table): void {
2224
$table->id();
2325
$table->string('name');
2426
$table->string('email')->unique();
@@ -27,7 +29,7 @@
2729
});
2830
});
2931

30-
it('can create, find, update, delete, and search users', function () {
32+
it('can create, find, update, delete, and search users', function (): void {
3133
// Define a simple User model
3234
eval('class TestUser extends \\Illuminate\\Database\\Eloquent\\Model { protected $table = "users"; protected $fillable = ["name", "email", "password"]; public $timestamps = true; }');
3335
$userModel = new TestUser();
@@ -72,4 +74,4 @@
7274
expect($deleted)->toBeTrue();
7375
expect($repo->find($user->id))->toBeNull();
7476
});
75-
});
77+
});

0 commit comments

Comments
 (0)