Improved Heart displaying for entities

Author: LarsEsDoch

src/main/java/dev/lars/utilsmanager/UtilsManager.java

@@ -3,6 +3,7 @@
 import com.comphenix.protocol.ProtocolLibrary;
 import com.comphenix.protocol.ProtocolManager;
 import dev.lars.utilsmanager.entity.EntitySummons;
+import dev.lars.utilsmanager.entity.HeartDisplayManager;
 import dev.lars.utilsmanager.features.backpack.BackpackManager;
 import dev.lars.utilsmanager.features.court.CourtManager;
 import dev.lars.utilsmanager.features.freecam.FreeCamManager;
@@ -35,6 +36,7 @@ public final class UtilsManager extends JavaPlugin {
     private TablistManager tablistManager;
     private RankManager rankManager;
     private EntitySummons entitySummons;
+    private HeartDisplayManager heartDisplayManager;
     private QuestManager questManager;
     private BanManager banManager;
     private CourtManager courtManager;
@@ -77,6 +79,7 @@ private void initializeManagers() {
         new RealTime();
         new BedListener();
         entitySummons = new EntitySummons();
+        heartDisplayManager = new HeartDisplayManager();
         courtManager = new CourtManager();
         banManager = new BanManager();
         new TeleporterListener();
@@ -102,7 +105,7 @@ private void initializeDiscordBot() {
 
     private void registerGameFeatures() {
         new RecipeLoader().registerRecipes();
-        entitySummons.EntityHearths();
+        heartDisplayManager.start();
         rankManager.checkRanks();
     }
 

src/main/java/dev/lars/utilsmanager/entity/EntitySummons.java

@@ -147,38 +147,6 @@ public void EntitysSummons() {
         wchicken3.customName(Component.text("Kjelli"));
     }
 
-    public void EntityHearths() {
-        Bukkit.getScheduler().runTaskTimer(UtilsManager.getInstance(), bukkitTask -> {
-            for (Player player : Bukkit.getOnlinePlayers()) {
-                for (Entity entity : player.getNearbyEntities(20, 20, 20)) {
-                    if (!(entity instanceof Monster)) continue;
-
-                    Monster monster = (Monster) entity;
-                    int healthInHearts = (int) Math.ceil(monster.getHealth() / 2);
-
-                    String name = entity.customName() != null
-                            ? PlainTextComponentSerializer.plainText().serialize(entity.customName())
-                            : null;
-
-                    if (name == null || !name.contains("❤")) {
-                        entity.setCustomNameVisible(true);
-                        entity.customName(Component.text(healthInHearts + "❤"));
-                    } else {
-                        String displayedHealthString = name.replace("❤", "").trim();
-                        try {
-                            int displayedHealth = Integer.parseInt(displayedHealthString);
-                            if (displayedHealth != healthInHearts) {
-                                entity.customName(Component.text(healthInHearts + "❤"));
-                            }
-                        } catch (NumberFormatException e) {
-                            entity.customName(Component.text(healthInHearts + "❤"));
-                        }
-                    }
-                }
-            }
-        }, 5, 5);
-    }
-
 
     public void EntitysSummonsEnd() {
         /*s1sheep.remove();
@@ -211,4 +179,4 @@ public void EntitysSummonsEnd() {
 
 
     }
-}
+}

src/main/java/dev/lars/utilsmanager/entity/HeartDisplayManager.java

@@ -0,0 +1,70 @@
+package dev.lars.utilsmanager.entity;
+
+import dev.lars.utilsmanager.UtilsManager;
+import net.kyori.adventure.text.Component;
+import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer;
+import org.bukkit.Bukkit;
+import org.bukkit.NamespacedKey;
+import org.bukkit.World;
+import org.bukkit.entity.Entity;
+import org.bukkit.entity.Monster;
+import org.bukkit.entity.Player;
+import org.bukkit.persistence.PersistentDataType;
+
+public class HeartDisplayManager {
+
+    private static final int VIEW_RADIUS = 20;
+    private static final long INITIAL_DELAY = 10L;
+    private static final long INTERVAL = 10L;
+
+    private final NamespacedKey heartsKey;
+
+    public HeartDisplayManager() {
+        this.heartsKey = new NamespacedKey(UtilsManager.getInstance(), "displayed_hearts");
+    }
+
+    public void start() {
+        Bukkit.getScheduler().runTaskTimer(UtilsManager.getInstance(), this::tick, INITIAL_DELAY, INTERVAL);
+    }
+
+    private void tick() {
+        PlainTextComponentSerializer plain = PlainTextComponentSerializer.plainText();
+
+        for (World world : Bukkit.getWorlds()) {
+            for (Monster monster : world.getEntitiesByClass(Monster.class)) {
+
+                if (monster.isDead()) continue;
+
+                Component custom = monster.customName();
+                String plainName = custom != null ? plain.serialize(custom) : null;
+                boolean hasHeartLabel = plainName != null && plainName.contains("❤");
+
+                if (plainName != null && !hasHeartLabel) continue;
+
+                int hearts = (int) Math.ceil(monster.getHealth() / 2.0);
+
+                boolean playerNearby = monster.getNearbyEntities(VIEW_RADIUS, VIEW_RADIUS, VIEW_RADIUS)
+                                             .stream().anyMatch(e -> e instanceof Player);
+
+                if (!playerNearby) {
+                    if (monster.getPersistentDataContainer().has(heartsKey, PersistentDataType.INTEGER)) {
+                        monster.setCustomNameVisible(false);
+                    }
+                    continue;
+                }
+
+                int previous = -1;
+                if (monster.getPersistentDataContainer().has(heartsKey, PersistentDataType.INTEGER)) {
+                    previous = monster.getPersistentDataContainer().get(heartsKey, PersistentDataType.INTEGER);
+                }
+
+                if (previous != hearts || !hasHeartLabel) {
+                    monster.customName(Component.text(hearts + "❤"));
+                    monster.setCustomNameVisible(true);
+
+                    monster.getPersistentDataContainer().set(heartsKey, PersistentDataType.INTEGER, hearts);
+                }
+            }
+        }
+    }
+}