[graphql] SearchBy: Fixes false positive "Only one comparison operator allowed, found: xxx, not"

Author: LastDragon-ru

src/SearchBy/Directive.php

@@ -20,6 +20,7 @@
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators\Complex\Relation;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators\Logical\AllOf;
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators\Logical\AnyOf;
+use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators\Not;
 use Nuwave\Lighthouse\Schema\AST\DocumentAST;
 use Nuwave\Lighthouse\Schema\Directives\BaseDirective;
 use Nuwave\Lighthouse\Support\Contracts\ArgBuilderDirective;
@@ -141,13 +142,15 @@ public function manipulateArgDefinition(
     public function handleBuilder($builder, $value): EloquentBuilder|QueryBuilder {
         return (new SearchBuilder(
             (new Collection($this->scalars))
+                ->add(Not::class)
                 ->flatten()
                 ->unique()
                 ->filter(static function (string $operator): bool {
                     return class_exists($operator);
                 })->map(function (string $operator): object {
                     return $this->container->make($operator);
-                })->all(),
+                })
+                ->all(),
         ))->build($builder, $value);
     }
 }

src/SearchBy/DirectiveTest.php

@@ -2,7 +2,12 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\SearchBy;
 
+use Closure;
+use Exception;
+use LastDragon_ru\LaraASP\GraphQL\Testing\BuilderDataProvider;
 use LastDragon_ru\LaraASP\GraphQL\Testing\TestCase;
+use LastDragon_ru\LaraASP\Testing\Providers\ArrayDataProvider;
+use LastDragon_ru\LaraASP\Testing\Providers\CompositeDataProvider;
 use LastDragon_ru\LaraASP\Testing\Utils\WithTestData;
 
 /**
@@ -25,6 +30,24 @@ public function testManipulateArgDefinition(string $expected, string $graphql):
 
         $this->assertEquals($expected, $actual);
     }
+
+    /**
+     * @covers ::handleBuilder
+     *
+     * @dataProvider dataProviderHandleBuilder
+     *
+     * @param array<mixed> $input
+     */
+    public function testHandleBuilder(bool|Exception $expected, Closure $builder, array $input): void {
+        if ($expected instanceof Exception) {
+            $this->expectExceptionObject($expected);
+        }
+
+        $builder   = $builder($this);
+        $directive = new Directive($this->app, [], []);
+
+        $this->assertNotNull($directive->handleBuilder($builder, $input));
+    }
     // </editor-fold>
 
     // <editor-fold desc="DataProvider">
@@ -38,5 +61,45 @@ public function dataProviderManipulateArgDefinition(): array {
             'only used type should be added' => ['~usedonly-expected.graphql', '~usedonly.graphql'],
         ];
     }
+
+    /**
+     * @return array<mixed>
+     */
+    public function dataProviderHandleBuilder(): array {
+        return (new CompositeDataProvider(
+            new BuilderDataProvider(),
+            new ArrayDataProvider([
+                'valid condition' => [
+                    true,
+                    [
+                        'not'   => 'yes',
+                        'allOf' => [
+                            [
+                                'a' => [
+                                    'eq'  => 1,
+                                    'not' => 'yes',
+                                ],
+                            ],
+                            [
+                                'anyOf' => [
+                                    [
+                                        'a' => [
+                                            'eq' => 2,
+                                        ],
+                                    ],
+                                    [
+                                        'b' => [
+                                            'eq'  => 3,
+                                            'not' => 'yes',
+                                        ],
+                                    ],
+                                ],
+                            ],
+                        ],
+                    ],
+                ],
+            ]),
+        ))->getData();
+    }
     // </editor-fold>
 }