AGS runtime engine crashes after running a game with FontRenderer Plugin enabled

[persn]

1. Add Plugin to AGS
2. Enable plugin to a game.
3. Add the function Test() somewhere it will be executed on run.
4. Run game.
5. Exit game. A dialog should now display with the run-time engine has crashed

[robertkety]

Is it crashing before the plugin runs the EditorShutdown() ?

[persn]

Haven't investigated it with the debugger. So I don't know where in the run line it crashes

[robertkety]

I suspect these issue are the result of manual assignment of delegates to memory locations without releasing them properly during shutdown. I wouldn't be surprised if we had to add a garbage collection function to the EdiorShutdown method.

[persn]

You mean EngineShutdown, not EditorShutdown right? The crash happened when I exited the game, not the edtior.

[robertkety]

Yes, Engine not Editor

[persn]

After some trial and error I've isolated the issue down to line 101 in AGSPlugin.cs of the FontRenderer plugin.

_fontRenderer = new MyFontRenderer(_engine);

Creating instances of MyFontRenderer creates the issue. I'm not sure why, it's obviously related to garbage collecting

[persn]

Isolated the issue down to a specific event (https://github.com/persn/AGSPluginSharp/commit/2bb00528500a94108db4965bd0cde059dc84dea0). Still don't understand how or why the engine crashes on shutdown, it appears to be crashing on calling any C# destructor, even if it does nothing.

[persn]

It suddenly occurred to me that I should've tested the plugins on the last confirmed AGS version it worked on, v3.2.1. It did not crash..

[persn]

As an experiment to move the native code to a more conventional compiler for open-source development, I discovered that the the native code triggers several warning when compiled under MingW(which VisualC++ doesn't seem to pick up on) in the destructors. The warnings typically read "warning: deleting object of polymorphic/abstract class type which has non-virtual destructor might cause undefined behavior". It might be related to the issue of engine crashing on game shut down.

https://github.com/persn/AGSPluginSharp/tree/mingw_codeblocks