Check for new ADB servers with min 5 second interval

Useful for cases where QP is opened THEN another app that kills the ADB server

Author: Lauriethefish

QuestPatcher.Core/AndroidDebugBridge.cs

@@ -72,7 +72,15 @@ public class AndroidDebugBridge
         private readonly Func<DisconnectionType, Task> _onDisconnect;
         private readonly string _adbExecutableName = OperatingSystem.IsWindows() ? "adb.exe" : "adb";
 
+        /// <summary>
+        /// The minimum time between checks for the currently open ADB daemon.
+        /// QP will automatically switch to a different ADB install if a daemon is started with that install. (and the install is new enough to work with QP.)
+        /// This allows QP to avoid killing an ADB daemon another app is using. (which would happen if it tried to use its own install and the versions were different.)
+        /// </summary>
+        private static readonly TimeSpan DaemonCheckInterval = TimeSpan.FromSeconds(5.0);
+
         private string? _adbPath;
+        private DateTime _lastDaemonCheck; // The last time at which QP checked for existing ADB daemons
         private Process? _logcatProcess;
 
         public AndroidDebugBridge(ExternalFilesDownloader filesDownloader, Func<DisconnectionType, Task> onDisconnect)
@@ -179,6 +187,8 @@ private async Task<bool> SetAdbPathIfValid(string adbExecutablePath)
 
         private async Task<bool> FindExistingAdbServer()
         {
+            _lastDaemonCheck = DateTime.Now;
+
             Log.Debug("Checking for existing daemon");
             foreach (string adbPath in FindRunningAdbPath())
             {
@@ -230,6 +240,14 @@ public async Task<ProcessOutput> RunCommand(string command, params int[] allowed
             {
                 await PrepareAdbPath();
             }
+            else
+            {
+                var now = DateTime.UtcNow;
+                if ((now - _lastDaemonCheck) > DaemonCheckInterval)
+                {
+                    await FindExistingAdbServer();
+                }
+            }
             Debug.Assert(_adbPath != null);
 
             Log.Debug("Executing ADB command: {Command}", $"adb {command}");