fix: linting and test typos

Author: grezle

pkg/commands/devnet_actions.go

@@ -74,7 +74,7 @@ func StartDevnetAction(cCtx *cli.Context) error {
 	}
 
 	// Check if docker is running, else try to start it
-	if skipForking == false {
+	if !skipForking {
 		if err := common.EnsureDockerIsRunning(cCtx); err != nil {
 
 			if errors.Is(err, context.Canceled) {
@@ -141,7 +141,7 @@ func StartDevnetAction(cCtx *cli.Context) error {
 	l2ChainDescription := fmt.Sprintf("against RPC %s", l2RpcUrl)
 
 	// Start anvil containers
-	if skipForking == false {
+	if !skipForking {
 		l1Port := cCtx.Int("l1-port")
 		l2Port := cCtx.Int("l2-port")
 
@@ -270,7 +270,7 @@ func StartDevnetAction(cCtx *cli.Context) error {
 	// On cancel, stop the containers if we're not skipping deployContracts/avsRun and we're not persisting
 	if !skipDeployContracts && !skipAvsRun && !persist {
 		defer func() {
-			if skipForking == false {
+			if !skipForking {
 				logger.Info("Stopping containers")
 				// Use background context to avoid cancellation issues during cleanup
 				bgCtx := context.Background()
@@ -372,7 +372,7 @@ func StartDevnetAction(cCtx *cli.Context) error {
 	// Deploy the contracts after starting devnet unless skipped
 	if !skipDeployContracts {
 		// We only need docker if we're forking locally
-		if skipForking == false {
+		if !skipForking {
 			// Check if docker is running, else try to start it
 			err := common.EnsureDockerIsRunning(cCtx)
 			if err != nil {

pkg/commands/transporter.go

@@ -504,7 +504,7 @@ func Transport(cCtx *cli.Context, initialRun bool) error {
 
 	for _, opset := range opsets {
 		// Only transport the configured AVSs operatorSets
-		if strings.ToLower(opset.Avs.Hex()) == strings.ToLower(envCtx.Avs.Address) {
+		if strings.EqualFold(opset.Avs.Hex(), envCtx.Avs.Address) {
 			err = stakeTransport.SignAndTransportAvsStakeTable(
 				cCtx.Context,
 				referenceTimestamp,

test/integration/migration/avs_context_0_1_1_to_0_1_2_test.go

@@ -59,13 +59,13 @@ context:
 
 	t.Run("mnemonic inserted with value", func(t *testing.T) {
 		// value node
-		val := migration.ResolveNode(migrated, []string{"context", "mnumonic"})
+		val := migration.ResolveNode(migrated, []string{"context", "mnemonic"})
 		if val == nil {
-			t.Fatalf("mnumonic key missing")
+			t.Fatalf("mnemonic key missing")
 		}
 		want := "test test test test test test test test test test test junk"
 		if val.Value != want {
-			t.Errorf("expected mnumonic value %q, got %q", want, val.Value)
+			t.Errorf("expected mnemonic value %q, got %q", want, val.Value)
 		}
 	})
 
@@ -76,38 +76,38 @@ context:
 			t.Fatalf("context mapping missing or wrong kind %d", ctx.Kind)
 		}
 		chainsIdx := -1
-		mnumonicIdx := -1
+		mnemonicIdx := -1
 		for i := 0; i < len(ctx.Content)-1; i += 2 {
 			k := ctx.Content[i]
 			switch k.Value {
 			case "chains":
 				chainsIdx = i
-			case "mnumonic":
-				mnumonicIdx = i
+			case "mnemonic":
+				mnemonicIdx = i
 			}
 		}
 		if chainsIdx < 0 {
 			t.Fatalf("context.chains key not found")
 		}
-		if mnumonicIdx < 0 {
-			t.Fatalf("context.mnumonic key not found")
+		if mnemonicIdx < 0 {
+			t.Fatalf("context.mnemonic key not found")
 		}
-		if mnumonicIdx != chainsIdx+2 {
-			t.Errorf("mnumonic not inserted immediately after chains: chainsIdx=%d mnumonicIdx=%d", chainsIdx, mnumonicIdx)
+		if mnemonicIdx != chainsIdx+2 {
+			t.Errorf("mnemonic not inserted immediately after chains: chainsIdx=%d mnemonicIdx=%d", chainsIdx, mnemonicIdx)
 		}
 	})
 
-	t.Run("comment attached to mnumonic key", func(t *testing.T) {
+	t.Run("comment attached to mnemonic key", func(t *testing.T) {
 		ctx := migration.ResolveNode(migrated, []string{"context"})
 		var keyNode *yaml.Node
 		for i := 0; i < len(ctx.Content)-1; i += 2 {
-			if ctx.Content[i].Value == "mnumonic" {
+			if ctx.Content[i].Value == "mnemonic" {
 				keyNode = ctx.Content[i]
 				break
 			}
 		}
 		if keyNode == nil {
-			t.Fatalf("mnumonic key node not found")
+			t.Fatalf("mnemonic key node not found")
 		}
 		wantComment := "Devnet mnemonic for unlocked accounts"
 		if keyNode.HeadComment != wantComment {