refactor: split telemetry command into subcommands and enable by default (#58)

Author: solimander

packages/cli/src/commands/telemetry.ts

@@ -0,0 +1,20 @@
+import { Command } from "@oclif/core";
+import { setGlobalTelemetryPreference, getGlobalTelemetryPreference } from "../../utils/globalConfig";
+import { withTelemetry } from "../../telemetry";
+
+export default class TelemetryDisable extends Command {
+  static description = "Disable telemetry collection";
+
+  async run() {
+    return withTelemetry(this, async () => {
+      const currentPreference = getGlobalTelemetryPreference();
+      if (currentPreference === false) {
+        this.log("\nTelemetry is already disabled");
+        return;
+      }
+
+      setGlobalTelemetryPreference(false);
+      this.log("\nTelemetry disabled");
+    });
+  }
+}

packages/cli/src/commands/telemetry/disable.ts

@@ -0,0 +1,20 @@
+import { Command } from "@oclif/core";
+import { setGlobalTelemetryPreference, getGlobalTelemetryPreference } from "../../utils/globalConfig";
+import { withTelemetry } from "../../telemetry";
+
+export default class TelemetryEnable extends Command {
+  static description = "Enable telemetry collection";
+
+  async run() {
+    return withTelemetry(this, async () => {
+      const currentPreference = getGlobalTelemetryPreference();
+      if (currentPreference === true) {
+        this.log("\nTelemetry is already enabled");
+        return;
+      }
+
+      setGlobalTelemetryPreference(true);
+      this.log("\nTelemetry enabled");
+    });
+  }
+}

packages/cli/src/commands/telemetry/enable.ts

@@ -0,0 +1,20 @@
+import { Command } from "@oclif/core";
+import { getGlobalTelemetryPreference } from "../../utils/globalConfig";
+import { withTelemetry } from "../../telemetry";
+
+export default class TelemetryStatus extends Command {
+  static description = "Show current telemetry status";
+
+  async run() {
+    return withTelemetry(this, async () => {
+      const globalPreference = getGlobalTelemetryPreference();
+      if (globalPreference === undefined) {
+        this.log("Telemetry: Enabled (default)");
+      } else if (globalPreference) {
+        this.log("Telemetry: Enabled");
+      } else {
+        this.log("Telemetry: Disabled");
+      }
+    });
+  }
+}

packages/cli/src/commands/telemetry/status.ts

@@ -33,7 +33,7 @@ export function createCLITelemetryClient(): TelemetryClient {
   const telemetryEnabled = getGlobalTelemetryPreference();
 
   return createTelemetryClient(environment, "ecloud-cli", {
-    telemetryEnabled: telemetryEnabled === true, // Only enabled if explicitly set to true
+    telemetryEnabled: telemetryEnabled !== false, // Enabled by default, disabled only if explicitly set to false
   });
 }