chore: remove deprecated types

Author: taekyunggg

packages/sdk/src/client/common/contract/caller.ts

@@ -225,25 +225,6 @@ export type DeployAppOptions = (CLIModeOptions | WalletClientModeOptions) & {
   imageRef: string;
 };
 
-/**
- * @deprecated Use DeployAppOptions with walletClient/publicClient for frontend mode
- * Legacy interface for backward compatibility
- */
-export interface DeployAppOptionsLegacy {
-  privateKey: string;
-  rpcUrl: string;
-  environmentConfig: EnvironmentConfig;
-  salt: Uint8Array;
-  release: Release;
-  publicLogs: boolean;
-  imageRef: string;
-  /** Optional gas params from estimation */
-  gas?: {
-    maxFeePerGas?: bigint;
-    maxPriorityFeePerGas?: bigint;
-  };
-}
-
 /**
  * CLI mode options for calculateAppID
  */
@@ -482,25 +463,6 @@ export type UpgradeAppOptions = (CLIModeOptions | WalletClientModeOptions) & {
   imageRef: string;
 };
 
-/**
- * @deprecated Use UpgradeAppOptions with walletClient/publicClient for frontend mode
- */
-export interface UpgradeAppOptionsLegacy {
-  privateKey: string;
-  rpcUrl: string;
-  environmentConfig: EnvironmentConfig;
-  appID: Address;
-  release: Release;
-  publicLogs: boolean;
-  needsPermissionChange: boolean;
-  imageRef: string;
-  /** Optional gas params from estimation */
-  gas?: {
-    maxFeePerGas?: bigint;
-    maxPriorityFeePerGas?: bigint;
-  };
-}
-
 /**
  * Upgrade app on-chain
  *
@@ -638,25 +600,6 @@ export type SendTransactionOptions = (
   txDescription: string;
 };
 
-/**
- * @deprecated Use SendTransactionOptions with walletClient/publicClient for frontend mode
- */
-export interface SendTransactionOptionsLegacy {
-  privateKey: string;
-  rpcUrl: string;
-  environmentConfig: EnvironmentConfig;
-  to: Address;
-  data: Hex;
-  value?: bigint;
-  pendingMessage: string;
-  txDescription: string;
-  /** Optional gas params from estimation */
-  gas?: {
-    maxFeePerGas?: bigint;
-    maxPriorityFeePerGas?: bigint;
-  };
-}
-
 export async function sendAndWaitForTransaction(
   options: SendTransactionOptions,
   logger: Logger

packages/sdk/src/client/common/contract/eip7702.ts

@@ -43,13 +43,13 @@ export interface EstimateBatchGasOptions {
 
 /**
  * Estimate gas cost for a batch transaction
- * 
+ *
  * Use this to get cost estimate before prompting user for confirmation.
  * Note: This provides a conservative estimate since batch transactions
  * through EIP-7702 can have variable costs.
  */
 export async function estimateBatchGas(
-  options: EstimateBatchGasOptions,
+  options: EstimateBatchGasOptions
 ): Promise<GasEstimate> {
   const { publicClient, executions } = options;
 
@@ -60,8 +60,8 @@ export async function estimateBatchGas(
   // Each execution adds ~50k gas, plus base cost of ~100k for the delegator call
   const baseGas = 100000n;
   const perExecutionGas = 50000n;
-  const estimatedGas = baseGas + (BigInt(executions.length) * perExecutionGas);
-  
+  const estimatedGas = baseGas + BigInt(executions.length) * perExecutionGas;
+
   // Add 20% buffer for safety
   const gasLimit = (estimatedGas * 120n) / 100n;
 
@@ -89,14 +89,11 @@ export interface ExecuteBatchOptions {
     callData: Hex;
   }>;
   pendingMessage: string;
-<<<<<<< HEAD
-  privateKey?: Hex; // Private key for signing raw hash (required for authorization signing)
   /** Optional gas params from estimation */
   gas?: {
     maxFeePerGas?: bigint;
     maxPriorityFeePerGas?: bigint;
   };
-=======
   /**
    * Private key for signing authorization (CLI mode).
    * If not provided, walletClient.signAuthorization() will be used (wallet client mode).
@@ -108,7 +105,6 @@ export interface ExecuteBatchOptions {
    * where the private key is not directly accessible.
    */
   useWalletClientSigning?: boolean;
->>>>>>> 12f912b (feat: add support for external signer instead of private key)
 }
 
 /**
@@ -149,11 +145,8 @@ export async function executeBatch(
     executions,
     pendingMessage,
     privateKey,
-<<<<<<< HEAD
     gas,
-=======
     useWalletClientSigning = false,
->>>>>>> 12f912b (feat: add support for external signer instead of private key)
   } = options;
 
   const account = walletClient.account;
@@ -286,26 +279,7 @@ export async function executeBatch(
     }
   }
 
-<<<<<<< HEAD
   // 5. Show pending message
-=======
-  // 5. Send transaction using viem
-  if (needsConfirmation) {
-    try {
-      const fees = await publicClient.estimateFeesPerGas();
-      const estimatedGas = 2000000n;
-      const maxCostWei = estimatedGas * fees.maxFeePerGas;
-      const costEth = formatETH(maxCostWei);
-      logger.info(
-        `${confirmationPrompt} on ${environmentConfig.name} (estimated max cost: ${costEth} ETH)`
-      );
-      // TODO: Add confirmation prompt
-    } catch (error) {
-      logger.warn(`Could not estimate cost for confirmation: ${error}`);
-    }
-  }
-
->>>>>>> 12f912b (feat: add support for external signer instead of private key)
   if (pendingMessage) {
     logger.info(pendingMessage);
   }
@@ -364,4 +338,4 @@ export async function executeBatch(
   }
 
   return hash;
-}
+}