validate operator sets

Author: 0xClandestine

src/contracts/core/EmissionsController.sol

@@ -30,13 +30,16 @@ contract EmissionsController is
     constructor(
         IEigen eigen,
         IBackingEigen backingEigen,
+        IAllocationManager allocationManager,
         IRewardsCoordinator rewardsCoordinator,
         IPauserRegistry pauserRegistry,
         uint256 inflationRate,
         uint256 startTime,
         uint256 cooldownSeconds
     )
-        EmissionsControllerStorage(eigen, backingEigen, rewardsCoordinator, inflationRate, startTime, cooldownSeconds)
+        EmissionsControllerStorage(
+            eigen, backingEigen, allocationManager, rewardsCoordinator, inflationRate, startTime, cooldownSeconds
+        )
         Pausable(pauserRegistry)
     {
         _disableInitializers();
@@ -302,7 +305,17 @@ contract EmissionsController is
         Distribution calldata distribution,
         uint256 currentEpoch,
         uint256 totalWeightBefore
-    ) internal pure {
+    ) internal view {
+        // Check if the operator set is registered (for OperatorSetTotalStake or OperatorSetUniqueStake distributions).
+        if (
+            distribution.distributionType == DistributionType.OperatorSetTotalStake
+                || distribution.distributionType == DistributionType.OperatorSetUniqueStake
+        ) {
+            if (!ALLOCATION_MANAGER.isOperatorSet(distribution.operatorSet)) {
+                revert OperatorSetNotRegistered();
+            }
+        }
+
         // Check if the start epoch is in the future.
         // Prevents updating a distribution to a past or current epoch.
         if (currentEpoch != type(uint256).max) {

src/contracts/core/storage/EmissionsControllerStorage.sol

@@ -19,6 +19,8 @@ abstract contract EmissionsControllerStorage is IEmissionsController {
     IEigen public immutable override EIGEN;
     /// @dev The backing Eigen token that will be minted for emissions.
     IBackingEigen public immutable override BACKING_EIGEN;
+    /// @dev The AllocationManager contract for managing operator sets.
+    IAllocationManager public immutable override ALLOCATION_MANAGER;
     /// @dev The RewardsCoordinator contract for submitting rewards.
     IRewardsCoordinator public immutable override REWARDS_COORDINATOR;
 
@@ -46,13 +48,15 @@ abstract contract EmissionsControllerStorage is IEmissionsController {
     constructor(
         IEigen eigen,
         IBackingEigen backingEigen,
+        IAllocationManager allocationManager,
         IRewardsCoordinator rewardsCoordinator,
         uint256 inflationRate,
         uint256 startTime,
         uint256 epochLength
     ) {
         EIGEN = eigen;
         BACKING_EIGEN = backingEigen;
+        ALLOCATION_MANAGER = allocationManager;
         REWARDS_COORDINATOR = rewardsCoordinator;
 
         EMISSIONS_INFLATION_RATE = inflationRate;

src/contracts/interfaces/IEmissionsController.sol

@@ -25,6 +25,8 @@ interface IEmissionsControllerErrors {
     error InvalidDistributionType();
     /// @dev Thrown when rewards submissions array is empty for a distribution that requires it.
     error RewardsSubmissionsCannotBeEmpty();
+    /// @dev Thrown when the operator set is not registered.
+    error OperatorSetNotRegistered();
 }
 
 /// @title IEmissionsControllerTypes
@@ -128,6 +130,10 @@ interface IEmissionsController is IEmissionsControllerErrors, IEmissionsControll
     /// @dev Immutable/constant variable that requires an upgrade to modify.
     function BACKING_EIGEN() external view returns (IBackingEigen);
 
+    /// @notice The AllocationManager address.
+    /// @dev Immutable/constant variable that requires an upgrade to modify.
+    function ALLOCATION_MANAGER() external view returns (IAllocationManager);
+
     /// @notice The RewardsCoordinator address.
     /// @dev Immutable/constant variable that requires an upgrade to modify.
     function REWARDS_COORDINATOR() external view returns (IRewardsCoordinator);

src/test/unit/EmissionsControllerUnit.t.sol

@@ -25,6 +25,7 @@ contract EmissionsControllerUnitTests is EigenLayerUnitTestSetup, IEmissionsCont
                         new EmissionsController(
                             IEigen(address(eigenMock)),
                             IBackingEigen(address(backingEigenMock)),
+                            IAllocationManager(address(allocationManagerMock)),
                             IRewardsCoordinator(address(rewardsCoordinatorMock)),
                             IPauserRegistry(address(pauserRegistry)),
                             EMISSIONS_INFLATION_RATE,