Skip to content

Commit 78c6200

Browse files
committed
chore: cleanup interfaces
1 parent 62d597d commit 78c6200

File tree

11 files changed

+316
-11
lines changed

11 files changed

+316
-11
lines changed

audits/Slashing-UX-Improvements-Audit-Findings.md

Lines changed: 299 additions & 0 deletions
Large diffs are not rendered by default.

pkg/bindings/AllocationManager/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/AllocationManagerView/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/CrossChainRegistry/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/DelegationManager/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/KeyRegistrar/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/RewardsCoordinator/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/StrategyManager/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

script/releases/TestUtils.sol

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,10 @@ library TestUtils {
606606
allocationManagerView.ALLOCATION_CONFIGURATION_DELAY() == Env.ALLOCATION_CONFIGURATION_DELAY(),
607607
"allocationManagerView ALLOCATION_CONFIGURATION_DELAY incorrect"
608608
);
609+
assertTrue(
610+
allocationManagerView.SLASHER_CONFIGURATION_DELAY() == Env.ALLOCATION_CONFIGURATION_DELAY(),
611+
"allocationManagerView SLASHER_CONFIGURATION_DELAY incorrect"
612+
);
609613
}
610614

611615
function validateAllocationManagerImmutables(
@@ -637,6 +641,10 @@ library TestUtils {
637641
allocationManager.ALLOCATION_CONFIGURATION_DELAY() == Env.ALLOCATION_CONFIGURATION_DELAY(),
638642
"allocationManager ALLOCATION_CONFIGURATION_DELAY incorrect"
639643
);
644+
assertTrue(
645+
allocationManager.SLASHER_CONFIGURATION_DELAY() == Env.ALLOCATION_CONFIGURATION_DELAY(),
646+
"allocationManager SLASHER_CONFIGURATION_DELAY incorrect"
647+
);
640648
}
641649

642650
function validateAVSDirectoryImmutables(

src/contracts/core/storage/AllocationManagerStorage.sol

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ abstract contract AllocationManagerStorage is IAllocationManagerStorage {
4444
uint32 public immutable ALLOCATION_CONFIGURATION_DELAY;
4545

4646
/// @notice Delay before slasher changes take effect.
47-
/// @dev Currently set to the same value as ALLOCATION_CONFIGURATION_DELAY but
48-
/// can be changed independently in future upgrades.
47+
/// @dev Currently set to the same value as ALLOCATION_CONFIGURATION_DELAY.
4948
uint32 public immutable SLASHER_CONFIGURATION_DELAY;
5049

5150
// Mutatables
@@ -136,7 +135,6 @@ abstract contract AllocationManagerStorage is IAllocationManagerStorage {
136135
eigenStrategy = _eigenStrategy;
137136
DEALLOCATION_DELAY = _DEALLOCATION_DELAY;
138137
ALLOCATION_CONFIGURATION_DELAY = _ALLOCATION_CONFIGURATION_DELAY;
139-
// Set to same value as ALLOCATION_CONFIGURATION_DELAY for now
140138
SLASHER_CONFIGURATION_DELAY = _ALLOCATION_CONFIGURATION_DELAY;
141139
}
142140

0 commit comments

Comments
 (0)