fix(rewards): address v2.2 audit findings

- Table 16: use slashing-adjusted base for staker split calculation
- Table 17/20: evaluate refunds per operator-set/operator, not per-snapshot
- operatorShareSnapshots: apply allocations to all backfill days, include cutoff snapshot

Author: serichoi65

pkg/rewards/17_goldAvsOperatorSetUniqueStakeRewards.go

@@ -23,17 +23,20 @@ WITH total_available_tokens AS (
     GROUP BY reward_hash, snapshot, token, avs, operator_set_id, operator
 ),
 
--- Step 2: Calculate total tokens actually distributed from the operator rewards table
+-- Step 2: Calculate total tokens actually distributed per operator from the operator rewards table
 total_distributed_tokens AS (
     SELECT
         reward_hash,
         snapshot,
+        avs,
+        operator_set_id,
+        operator,
         COALESCE(SUM(operator_tokens), 0) as distributed_tokens
     FROM {{.operatorRewardsTable}}
-    GROUP BY reward_hash, snapshot
+    GROUP BY reward_hash, snapshot, avs, operator_set_id, operator
 ),
 
--- Step 3: Identify snapshots where distributed tokens = 0, refund all available tokens to AVS
+-- Step 3: Identify operator-sets where distributed tokens = 0, refund those tokens to AVS
 snapshots_requiring_refund AS (
     SELECT
         tat.reward_hash,
@@ -47,6 +50,9 @@ snapshots_requiring_refund AS (
     LEFT JOIN total_distributed_tokens tdt
         ON tat.reward_hash = tdt.reward_hash
         AND tat.snapshot = tdt.snapshot
+        AND tat.avs = tdt.avs
+        AND tat.operator_set_id = tdt.operator_set_id
+        AND tat.operator = tdt.operator
     WHERE COALESCE(tdt.distributed_tokens, 0) = 0
 )
 

pkg/rewards/20_goldAvsOperatorSetTotalStakeRewards.go

@@ -23,17 +23,20 @@ WITH total_available_tokens AS (
     GROUP BY reward_hash, snapshot, token, avs, operator_set_id, operator
 ),
 
--- Step 2: Calculate total tokens actually distributed from the operator rewards table
+-- Step 2: Calculate total tokens actually distributed per operator from the operator rewards table
 total_distributed_tokens AS (
     SELECT
         reward_hash,
         snapshot,
+        avs,
+        operator_set_id,
+        operator,
         COALESCE(SUM(operator_tokens), 0) as distributed_tokens
     FROM {{.operatorRewardsTable}}
-    GROUP BY reward_hash, snapshot
+    GROUP BY reward_hash, snapshot, avs, operator_set_id, operator
 ),
 
--- Step 3: Identify snapshots where distributed tokens = 0, refund all available tokens to AVS
+-- Step 3: Identify operator-sets where distributed tokens = 0, refund those tokens to AVS
 snapshots_requiring_refund AS (
     SELECT
         tat.reward_hash,
@@ -47,6 +50,9 @@ snapshots_requiring_refund AS (
     LEFT JOIN total_distributed_tokens tdt
         ON tat.reward_hash = tdt.reward_hash
         AND tat.snapshot = tdt.snapshot
+        AND tat.avs = tdt.avs
+        AND tat.operator_set_id = tdt.operator_set_id
+        AND tat.operator = tdt.operator
     WHERE COALESCE(tdt.distributed_tokens, 0) = 0
 )
 

pkg/rewards/operatorShareSnapshots.go

@@ -30,8 +30,8 @@ operator_share_windows as (
 	SELECT
 		operator, strategy, shares, snapshot_time as start_time,
 		CASE
-			-- If the range does not have the end, use the current timestamp truncated to 0 UTC
-			WHEN LEAD(snapshot_time) OVER (PARTITION BY operator, strategy ORDER BY snapshot_time) is null THEN date_trunc('day', TIMESTAMP '{{.cutoffDate}}')
+			-- If the range does not have the end, use cutoff + 1 day to include cutoff date snapshot
+			WHEN LEAD(snapshot_time) OVER (PARTITION BY operator, strategy ORDER BY snapshot_time) is null THEN date_trunc('day', TIMESTAMP '{{.cutoffDate}}') + INTERVAL '1' day
 			ELSE LEAD(snapshot_time) OVER (PARTITION BY operator, strategy ORDER BY snapshot_time)
 		END AS end_time
 	FROM snapshotted_records
@@ -51,15 +51,15 @@ base_snapshots as (
 	CROSS JOIN
 		generate_series(DATE(start_time), DATE(end_time) - interval '1' day, interval '1' day) AS day
 ),
--- Add operator allocations (deallocation delay handled via effective_block)
+-- Add operator allocations for all days in the generated window
 allocation_adjustments as (
 	SELECT
 		oas.operator,
 		oas.strategy,
 		SUM(oas.magnitude) as total_magnitude,
 		oas.snapshot
 	FROM operator_allocation_snapshots oas
-	WHERE oas.snapshot = DATE '{{.snapshotDate}}'
+	WHERE oas.snapshot < DATE '{{.snapshotDate}}'
 	GROUP BY oas.operator, oas.strategy, oas.snapshot
 ),
 combined_snapshots as (