fix: adding clearance at the top of the tab and compartment walls to improve bin stacking

addressing #20

Author: Le0Michine

lib/gridfinityUtils/binBodyCutoutGenerator.py

@@ -72,15 +72,16 @@ def createGridfinityBinBodyCutout(
         True,
         targetComponent
     )
-    # recalculate faces after fillet
-    [innerCutoutScoopFace, innerCutoputScoopOppositeFace] = getInnerCutoutScoopFace(innerCutoutBody)
-    scoopOppositeEdge = faceUtils.getBottomHorizontalEdge(innerCutoputScoopOppositeFace.edges)
+    if input.hasBottomFillet:
+        # recalculate faces after fillet
+        [innerCutoutScoopFace, innerCutoputScoopOppositeFace] = getInnerCutoutScoopFace(innerCutoutBody)
+        scoopOppositeEdge = faceUtils.getBottomHorizontalEdge(innerCutoputScoopOppositeFace.edges)
 
-    filletUtils.createFillet(
-        [scoopOppositeEdge],
-        input.filletRadius,
-        True,
-        targetComponent
-    )
+        filletUtils.createFillet(
+            [scoopOppositeEdge],
+            input.filletRadius,
+            True,
+            targetComponent
+        )
 
     return innerCutoutBody

lib/gridfinityUtils/binBodyCutoutGeneratorInput.py

@@ -10,6 +10,7 @@ def __init__(self):
         self.tabPosition = 0
         self.tabLength = 1
         self.tabWidth = const.BIN_TAB_WIDTH
+        self.hasBottomFillet = True
 
 
     @property
@@ -60,6 +61,14 @@ def scoopMaxRadius(self) -> float:
     def scoopMaxRadius(self, value: float):
         self._scoopMaxRadius = value
 
+    @property
+    def hasBottomFillet(self) -> float:
+        return self._hasBottomFillet
+
+    @hasBottomFillet.setter
+    def hasBottomFillet(self, value: float):
+        self._hasBottomFillet = value
+
     @property
     def filletRadius(self) -> float:
         return self._filletRadius

lib/gridfinityUtils/binBodyGenerator.py

@@ -124,28 +124,60 @@ def createGridfinityBinBody(
         for compartment in input.compartments:
             compartmentX = compartmentsMinX + compartment.positionX * (compartmentWidthUnit + input.wallThickness)
             compartmentY = compartmentsMinY + compartment.positionY * (compartmentLengthUnit + input.wallThickness)
+            compartmentOriginPoint = adsk.core.Point3D.create(
+                compartmentX,
+                compartmentY,
+                binBodyTotalHeight
+            )
+            compartmentWidth = compartmentWidthUnit * compartment.width + (compartment.width - 1) * input.wallThickness
+            compartmentLength = compartmentLengthUnit * compartment.length + (compartment.length - 1) * input.wallThickness
+            compartmentDepth = min(binBodyTotalHeight - const.BIN_COMPARTMENT_BOTTOM_THICKNESS, compartment.depth)
+
+            compartmentTabInput = BinBodyTabGeneratorInput()
+            tabOriginPoint = adsk.core.Point3D.create(
+                compartmentOriginPoint.x + max(0, min(input.tabPosition, input.binWidth - input.tabLength)) * input.baseWidth,
+                compartmentOriginPoint.y + compartmentLength,
+                compartmentOriginPoint.z,
+            )
+            compartmentTabInput.origin = tabOriginPoint
+            compartmentTabInput.length = max(0, min(input.tabLength, input.binWidth)) * input.baseWidth
+            compartmentTabInput.width = input.tabWidth
+            compartmentTabInput.overhangAngle = input.tabOverhangAngle
+            compartmentTabInput.topClearance = const.BIN_TAB_TOP_CLEARANCE
+
             [compartmentMerges, compartmentCuts] = createCompartment(
                 input.wallThickness,
-                adsk.core.Point3D.create(
-                    compartmentX,
-                    compartmentY,
-                    binBodyTotalHeight
-                ),
-                compartmentWidthUnit * compartment.width + (compartment.width - 1) * input.wallThickness,
-                compartmentLengthUnit * compartment.length + (compartment.length - 1) * input.wallThickness,
-                min(binBodyTotalHeight - const.BIN_COMPARTMENT_BOTTOM_THICKNESS, compartment.depth),
+                compartmentOriginPoint,
+                compartmentWidth,
+                compartmentLength,
+                compartmentDepth,
                 input.hasScoop,
                 input.scoopMaxRadius,
                 input.hasTab,
-                max(0, min(input.tabLength, input.binWidth)) * input.baseWidth,
-                input.tabWidth,
-                max(0, min(input.tabPosition, input.binWidth - input.tabLength)) * input.baseWidth,
-                input.tabOverhangAngle,
+                compartmentTabInput,
                 targetComponent,
             )
             bodiesToSubtract = bodiesToSubtract + compartmentCuts
             bodiesToMerge = bodiesToMerge + compartmentMerges
 
+        if len(input.compartments) > 1:
+            compartmentsTopClearance = createCompartmentCutout(
+                input.wallThickness,
+                adsk.core.Point3D.create(
+                    compartmentsMinX,
+                    compartmentsMinY,
+                    binBodyTotalHeight
+                ),
+                actualBodyWidth - input.wallThickness * 2,
+                actualBodyLength - input.wallThickness * 2,
+                const.BIN_TAB_TOP_CLEARANCE,
+                False,
+                0,
+                False,
+                targetComponent,
+            )
+            bodiesToSubtract.append(compartmentsTopClearance)
+
     if len(bodiesToSubtract) > 0:
         combineUtils.cutBody(
             binBody,
@@ -162,24 +194,18 @@ def createGridfinityBinBody(
     return binBody
 
 
-def createCompartment(
+def createCompartmentCutout(
         wallThickness: float,
         originPoint: adsk.core.Point3D,
         width: float,
         length: float,
         depth: float,
         hasScoop: bool,
         scoopMaxRadius: float,
-        hasTab: bool,
-        tabLength: float,
-        tabWidth: float,
-        tabPosition: float,
-        tabOverhangAngle: float,
+        hasBottomFillet: bool,
         targetComponent: adsk.fusion.Component,
-    ) -> tuple[list[adsk.fusion.BRepBody], list[adsk.fusion.BRepBody]]:
+    ) -> adsk.fusion.BRepBody:
 
-    bodiesToMerge: list[adsk.fusion.BRepBody] = []
-    bodiesToSubtract: list[adsk.fusion.BRepBody] = []
     innerCutoutFilletRadius = max(const.BIN_BODY_CUTOUT_BOTTOM_FILLET_RADIUS, const.BIN_CORNER_FILLET_RADIUS - wallThickness)
     innerCutoutInput = BinBodyCutoutGeneratorInput()
     innerCutoutInput.origin = originPoint
@@ -188,28 +214,42 @@ def createCompartment(
     innerCutoutInput.height = depth
     innerCutoutInput.hasScoop = hasScoop
     innerCutoutInput.scoopMaxRadius = scoopMaxRadius
-    innerCutoutInput.hasTab = hasTab
-    innerCutoutInput.tabLength = tabLength
-    innerCutoutInput.tabWidth = tabWidth
-    innerCutoutInput.tabPosition = tabPosition
-    innerCutoutInput.tabOverhangAngle = tabOverhangAngle
     innerCutoutInput.filletRadius = innerCutoutFilletRadius
+    innerCutoutInput.hasBottomFillet = hasBottomFillet
 
-    innerCutoutBody = createGridfinityBinBodyCutout(innerCutoutInput, targetComponent)
+    return createGridfinityBinBodyCutout(innerCutoutInput, targetComponent)
+
+def createCompartment(
+        wallThickness: float,
+        originPoint: adsk.core.Point3D,
+        width: float,
+        length: float,
+        depth: float,
+        hasScoop: bool,
+        scoopMaxRadius: float,
+        hasTab: bool,
+        tabInput: BinBodyTabGeneratorInput,
+        targetComponent: adsk.fusion.Component,
+    ) -> tuple[list[adsk.fusion.BRepBody], list[adsk.fusion.BRepBody]]:
+
+    bodiesToMerge: list[adsk.fusion.BRepBody] = []
+    bodiesToSubtract: list[adsk.fusion.BRepBody] = []
+
+    innerCutoutBody = createCompartmentCutout(
+        wallThickness,
+        originPoint,
+        width,
+        length,
+        depth,
+        hasScoop,
+        scoopMaxRadius,
+        True,
+        targetComponent,
+    )
     bodiesToSubtract.append(innerCutoutBody)
 
     # label tab
     if hasTab:
-        tabInput = BinBodyTabGeneratorInput()
-        tabOriginPoint = adsk.core.Point3D.create(
-            originPoint.x + tabPosition,
-            originPoint.y + length,
-            innerCutoutInput.origin.z,
-        )
-        tabInput.origin = tabOriginPoint
-        tabInput.length = tabLength
-        tabInput.width = tabWidth
-        tabInput.overhangAngle = tabOverhangAngle
         tabBody = createGridfinityBinBodyTab(tabInput,targetComponent)
 
         intersectTabInput = targetComponent.features.combineFeatures.createInput(

lib/gridfinityUtils/binBodyLipGenerator.py

@@ -5,13 +5,8 @@
 from .const import BIN_CORNER_FILLET_RADIUS
 from ...lib import fusion360utils as futil
 from . import const, combineUtils, faceUtils, commonUtils, sketchUtils, extrudeUtils, baseGenerator, edgeUtils, filletUtils, geometryUtils
-from .binBodyCutoutGenerator import createGridfinityBinBodyCutout
-from .binBodyCutoutGeneratorInput import BinBodyCutoutGeneratorInput
 from .baseGeneratorInput import BaseGeneratorInput
 from .binBodyLipGeneratorInput import BinBodyLipGeneratorInput
-from .binBodyTabGeneratorInput import BinBodyTabGeneratorInput
-from .binBodyTabGenerator import createGridfinityBinBodyTab
-from ... import config
 
 app = adsk.core.Application.get()
 ui = app.userInterface

lib/gridfinityUtils/binBodyTabGenerator.py

@@ -38,7 +38,7 @@ def createGridfinityBinBodyTab(
     tabSketch: adsk.fusion.Sketch = targetComponent.sketches.add(tabProfilePlane)
     tabSketch.name = "tab sketch"
     tabSketchLine = tabSketch.sketchCurves.sketchLines
-    tabTopEdgeHeight = input.origin.z
+    tabTopEdgeHeight = input.origin.z - input.topClearance
     actualTabWidth = input.width + BIN_TAB_EDGE_FILLET_RADIUS / math.tan((math.radians(90) - input.overhangAngle) / 2)
     actualTabHeight = actualTabWidth / math.tan(input.overhangAngle)
     line1 = tabSketchLine.addByTwoPoints(

lib/gridfinityUtils/binBodyTabGeneratorInput.py

@@ -7,6 +7,14 @@ def __init__(self):
         self.overhangAngle = const.BIN_TAB_OVERHANG_ANGLE
         self.position = 0
 
+    @property
+    def topClearance(self) -> float:
+        return self._topClearance
+
+    @topClearance.setter
+    def topClearance(self, value: float):
+        self._topClearance = value
+
     @property
     def width(self) -> float:
         return self._baseWidth

lib/gridfinityUtils/const.py

@@ -20,6 +20,7 @@
 BIN_TAB_WIDTH = 1.3
 BIN_TAB_OVERHANG_ANGLE = 45
 BIN_TAB_EDGE_FILLET_RADIUS = 0.06
+BIN_TAB_TOP_CLEARANCE = 0.025
 
 BIN_SCOOP_MAX_RADIUS = 2.5