cargo: clippy (updated version)

Author: LeChatP

rar-common/src/database/score.rs

@@ -104,7 +104,7 @@ impl From<&DGroupType<'_>> for SetgidMin {
 impl From<&Vec<u32>> for SetgidMin {
     fn from(s: &Vec<u32>) -> Self {
         SetgidMin {
-            is_root: s.iter().any(|id| *id == 0),
+            is_root: s.contains(&0),
             nb_groups: s.len(),
         }
     }

rar-common/src/util.rs

@@ -313,8 +313,7 @@ pub fn write_json_config<T: Serialize>(settings: &T, file: &mut impl Write) -> s
 
 pub fn write_cbor_config<T: Serialize>(settings: &T, file: &mut impl Write) -> std::io::Result<()> {
     cbor4ii::serde::to_writer(file, &settings).map_err(|e| {
-        std::io::Error::new(
-            std::io::ErrorKind::Other,
+        std::io::Error::other(
             format!("Failed to write cbor config: {}", e),
         )
     })

src/sr/error.rs

@@ -183,7 +183,7 @@ mod tests {
         let sr_error: SrError = not_found.into();
         assert_eq!(sr_error, SrError::ExecutionFailed);
 
-        let other = std::io::Error::new(std::io::ErrorKind::Other, "test");
+        let other = std::io::Error::other("test");
         let sr_error: SrError = other.into();
         assert_eq!(sr_error, SrError::SystemError);
     }

src/sr/finder/cmd.rs

@@ -24,7 +24,7 @@ fn match_path(
             info!("match_path: found better match {:?}", min);
             *final_path = Some(user_path.clone());
         }
-        return min;
+        min
     } else {
         debug!("match_path: user relative path");
         let mut curmin = CmdMin::empty();

src/sr/finder/de.rs

@@ -968,12 +968,12 @@ impl<'de: 'a, 'a> DeserializeSeed<'de> for SetGroupsDeserializerReturn<'a> {
                         }
                         Field::Add => {
                             debug!("SGroupsChooserVisitor: add");
-                            if filter.is_some() {
+                            if let Some(filter) = filter {
                                 let add = map.next_value::<Cow<'_, [DGroups]>>()?;
                                 for group in add.iter() {
                                     let v: Vec<u32> =
                                         group.try_into().map_err(serde::de::Error::custom)?;
-                                    if v == *filter.unwrap() {
+                                    if v == *filter {
                                         ok = true;
                                         groups = Some(group.to_owned());
                                         score.replace(group.into());
@@ -1164,13 +1164,13 @@ impl<'de: 'a, 'a> DeserializeSeed<'de> for SetUserDeserializerReturn<'a> {
                         }
                         Field::Add => {
                             debug!("SUserChooserVisitor: add");
-                            if filter.is_some() {
+                            if let Some(filter) = filter {
                                 let users = map.next_value::<Cow<'_, [DUserType]>>()?;
                                 for user_item in users.iter() {
                                     let user_id = user_item
                                         .fetch_id()
                                         .ok_or(serde::de::Error::custom("User does not exist"))?;
-                                    if user_id == *filter.unwrap() {
+                                    if user_id == *filter {
                                         ok = true;
                                         user = Some(user_item.to_owned());
                                         score.replace(user_item.into());

src/sr/pam/rpassword.rs

@@ -79,6 +79,7 @@ fn read_unbuffered(source: &mut impl io::Read) -> io::Result<PamBuffer> {
     let mut pwd_iter = password.iter_mut();
 
     const EOL: u8 = 0x0A;
+    #[allow(clippy::unbuffered_bytes)] // we want unbuffered reading for passwords
     let input = source.bytes().take_while(|x| x.as_ref().ok() != Some(&EOL));
 
     for read_byte in input {