style: rustfmt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: budlibu500

crates/ltk_ritobin/tests/parse_sample.rs

@@ -245,7 +245,7 @@ fn test_matrix44_roundtrip_ordering() {
     //
     // glam is column-major internally so:
     let expected = Mat4::from_cols_array(&[
-        1.0, 5.0, 9.0, 13.0,  // col0
+        1.0, 5.0, 9.0, 13.0, // col0
         2.0, 6.0, 10.0, 14.0, // col1
         3.0, 7.0, 11.0, 15.0, // col2
         4.0, 8.0, 12.0, 16.0, // col3
@@ -274,18 +274,28 @@ entries: map[hash,embed] = {
         PropertyValueEnum::Matrix44(v) => v.value,
         other => panic!("Expected Matrix44, got {:?}", other),
     };
-    assert_eq!(parsed_mat, expected, "Parsed Mat4 should match expected column-major layout");
+    assert_eq!(
+        parsed_mat, expected,
+        "Parsed Mat4 should match expected column-major layout"
+    );
 
     // 2) Write back to text, parse again, verify values survive the round-trip
     let output = write(&tree).expect("Failed to write tree");
     let file2 = parse(&output).expect("Failed to re-parse written output");
     let tree2 = file2.to_bin_tree();
-    let obj2 = tree2.objects.values().next().expect("Expected one object after round-trip");
+    let obj2 = tree2
+        .objects
+        .values()
+        .next()
+        .expect("Expected one object after round-trip");
     let roundtrip_mat = match &obj2.properties.values().next().unwrap().value {
         PropertyValueEnum::Matrix44(v) => v.value,
         other => panic!("Expected Matrix44 after round-trip, got {:?}", other),
     };
-    assert_eq!(roundtrip_mat, expected, "Matrix44 should survive text round-trip unchanged");
+    assert_eq!(
+        roundtrip_mat, expected,
+        "Matrix44 should survive text round-trip unchanged"
+    );
 }
 
 #[test]

matrix-fix.md

@@ -0,0 +1,56 @@
+# Matrix44 Transpose Bug Fix
+
+## Problem
+The text output for `transform: mtx44` was transposed. Translation value `-4500` appeared at `[row 1, col 3]` instead of `[row 3, col 1]`.
+
+**Wrong (before):**
+```
+transform: mtx44 = {
+    1, 0, 0, 0
+    0, 1, 0, -4500    <-- wrong position
+    0, 0, 1, 0
+    0, 0, 0, 1
+}
+```
+
+**Correct (after):**
+```
+transform: mtx44 = {
+    1, 0, 0, 0
+    0, 1, 0, 0
+    0, 0, 1, 0
+    0, -4500, 0, 1    <-- correct position
+}
+```
+
+## Root Cause
+`Matrix44Value` wrapped `glam::Mat4`, which stores data in column-major order internally. The reader (`read_mat4_row_major`) called `from_cols(...).transpose()` and the text writer called `v.0.transpose().to_cols_array()` — but these two transposes did not cancel out correctly when outputting to text, resulting in a transposed matrix.
+
+The reference C++ ritobin simply stores the matrix as a raw `std::array<float, 16>` and writes it back directly. No column-major/row-major conversion needed.
+
+## Fix
+Stop using `glam::Mat4` for `Matrix44Value`. Use `[f32; 16]` instead — read 16 floats, store 16 floats, write 16 floats. No transpose logic needed.
+
+### Changed Files
+
+#### 1. `ltk_meta/src/property/value/primitives.rs`
+- Replaced `impl_prim!(Matrix44Value, Mat4, [], mat4_row_major::<LE>, 0)` with a manual struct + impl
+- `Matrix44Value` now wraps `[f32; 16]` instead of `Mat4`
+- `ReadProperty::from_reader` reads 16 `f32` values sequentially
+- `WriteProperty::to_writer` writes 16 `f32` values sequentially
+
+#### 2. `ltk_ritobin/src/writer.rs` (line 225)
+- `let arr = v.0.transpose().to_cols_array()` → `let arr = v.0`
+- Since `v.0` is now `[f32; 16]` in binary order, just iterate directly
+
+#### 3. `ltk_ritobin/src/parser.rs` (text parser)
+- `parse_mtx44` return type: `Mat4` → `[f32; 16]`
+- `Mat4::from_cols_array(&values).transpose()` → `values`
+
+## Testing
+Standalone test project at `test_matrix/`:
+```bash
+cd test_matrix && cargo run 2>/dev/null | grep -A 6 "mtx44"
+```
+
+Verified output matches reference `ritobin_cli.exe` output.