Add more ruff rules, to enforce typing

Author: LeanderCS

flask_inputfilter/filters/to_base64_image_filter.py

@@ -70,7 +70,7 @@ def apply(self, value: Any) -> Any:
             try:
                 Image.open(io.BytesIO(base64.b64decode(value))).verify()
                 return value
-            except Exception:
+            except (ValueError, OSError, base64.binascii.Error):
                 pass
 
         # Try to open as raw bytes

flask_inputfilter/filters/to_image_filter.py

@@ -51,7 +51,7 @@ def apply(self, value: Any) -> Any:
             # Try to decode as base64
             try:
                 return Image.open(io.BytesIO(base64.b64decode(value)))
-            except Exception:
+            except (ValueError, OSError, base64.binascii.Error):
                 pass
 
         # Try to open as raw bytes

flask_inputfilter/filters/to_typed_dict_filter.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Any
+from typing import Any, Type
 
 from flask_inputfilter.models import BaseFilter
 
@@ -34,7 +34,7 @@ def __init__(self):
 
     __slots__ = ("typed_dict",)
 
-    def __init__(self, typed_dict) -> None:
+    def __init__(self, typed_dict: Type) -> None:
         """
         Parameters:
             typed_dict (Type[TypedDict]): The TypedDict class

flask_inputfilter/input_filter.py

@@ -104,7 +104,7 @@ def decorator(
             """
 
             def wrapper(
-                *args, **kwargs
+                *args: Any, **kwargs: Any
             ) -> Union[Response, tuple[Any, dict[str, Any]]]:
                 """
                 Wrapper function to handle input validation and error handling

flask_inputfilter/mixins/external_api_mixin/external_api_mixin.py

@@ -83,7 +83,7 @@ def call_external_api(
         request_data["method"] = config.method
 
         try:
-            response = requests.request(**request_data)
+            response = requests.request(timeout=30, **request_data)
             result = response.json()
         except requests.exceptions.RequestException:
             if fallback is None:

flask_inputfilter/validators/is_dataclass_validator.py

@@ -113,7 +113,7 @@ def __init__(
                 )
             )
 
-    def _format_error(self, error_type: str, **kwargs) -> str:
+    def _format_error(self, error_type: str, **kwargs: Any) -> str:
         """Format error message using template or custom message."""
         if self.error_message:
             return self.error_message

flask_inputfilter/validators/is_horizontal_image_validator.py

@@ -3,6 +3,7 @@
 import base64
 import binascii
 import io
+from typing import Any, Optional
 
 from PIL import Image
 from PIL.Image import Image as ImageType
@@ -41,10 +42,10 @@ def __init__(self):
 
     __slots__ = ("error_message",)
 
-    def __init__(self, error_message=None):
+    def __init__(self, error_message: Optional[str] = None) -> None:
         self.error_message = error_message
 
-    def validate(self, value):
+    def validate(self, value: Any) -> None:
         if not isinstance(value, (str, ImageType)):
             raise ValidationError(
                 "The value is not an image or its base 64 representation."

flask_inputfilter/validators/is_vertical_image_validator.py

@@ -42,7 +42,7 @@ def __init__(self):
 
     __slots__ = ("error_message",)
 
-    def __init__(self, error_message: Optional[str] = None):
+    def __init__(self, error_message: Optional[str] = None) -> None:
         self.error_message = (
             error_message or "The image is not vertically oriented."
         )

pyproject.toml

@@ -125,6 +125,16 @@ select = [
     "TCH",    # flake8-type-checking
     "PTH",    # flake8-use-pathlib
     "RUF",    # Ruff-specific rules
+    "S",      # flake8-bandit (Security)
+    "BLE",    # flake8-blind-except
+    "ANN",    # flake8-annotations
+    "ARG",    # flake8-unused-arguments
+    "ERA",    # eradicate
+    "PERF",   # Perflint
+    "FURB",   # refurb
+    "TRY",    # tryceratops
+    "SLF",    # flake8-self
+    "A",      # flake8-builtins
 ]
 fixable = ["ALL"]
 unfixable = []
@@ -136,11 +146,35 @@ ignore = [
     "UP006",  # Use `list` instead of `List` (Python 3.9+)
     "UP007",  # Use `X | Y` for unions (Python 3.10+)
     "UP035",  # Import from collections.abc (Python 3.9+)
+    "ANN101", # Missing type annotation for self
+    "ANN102", # Missing type annotation for cls
+    "ANN401", # Dynamically typed expressions (Any) - OK for flexible library
+    "TRY003", # Long exception messages (ok for Libraries)
+    "TRY300", # Consider moving to else block - not always applicable
+    "TRY301", # Abstract raise to inner function - not needed for simple cases
+    "PERF203", # try-except in loop - acceptable for validation patterns
+    "A001", # Variable shadowing builtin - OK in specific contexts (e.g. copyright)
+    "A002", # Variable shadowing builtin
 ]
 pyupgrade = [
     true
 ]
 
+[tool.ruff.lint.per-file-ignores]
+"tests/*" = [
+    "S101",    # Assert usage ist OK in Tests
+    "ANN",     # Type annotations optional in Tests
+    "ARG",     # Unused arguments OK in Test fixtures
+]
+"examples/*" = [
+    "ANN201",  # Missing return type annotation in examples
+    "ANN204",  # Missing return type annotation for __init__ in examples
+    "S201",    # debug=True is OK in examples
+]
+"docs/*" = [
+    "A001",    # Variable shadowing builtin (copyright) is OK in docs
+]
+
 [tool.ruff.lint.isort]
 force-single-line = false
 split-on-trailing-comma = true