Merge pull request #62 from LeanderCS/enforce-typing-with-ruff

Add more ruff rules, to enforce typing

Author: LeanderCS

docs/source/changelog.rst

@@ -3,6 +3,18 @@ Changelog
 
 All notable changes to this project will be documented in this file.
 
+[0.6.3] - 2025-09-24
+--------------------
+
+Added
+^^^^^
+- Added default timeout of 30s for external api requests.
+
+Changed
+^^^^^^^
+- Switched to more strict exception types for image filter.
+
+
 [0.6.2] - 2025-07-03
 --------------------
 

flask_inputfilter/filters/to_base64_image_filter.py

@@ -70,7 +70,7 @@ def apply(self, value: Any) -> Any:
             try:
                 Image.open(io.BytesIO(base64.b64decode(value))).verify()
                 return value
-            except Exception:
+            except (ValueError, OSError, base64.binascii.Error):
                 pass
 
         # Try to open as raw bytes

flask_inputfilter/filters/to_image_filter.py

@@ -51,7 +51,7 @@ def apply(self, value: Any) -> Any:
             # Try to decode as base64
             try:
                 return Image.open(io.BytesIO(base64.b64decode(value)))
-            except Exception:
+            except (ValueError, OSError, base64.binascii.Error):
                 pass
 
         # Try to open as raw bytes

flask_inputfilter/filters/to_typed_dict_filter.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Any
+from typing import Any, Type
 
 from flask_inputfilter.models import BaseFilter
 
@@ -34,7 +34,7 @@ def __init__(self):
 
     __slots__ = ("typed_dict",)
 
-    def __init__(self, typed_dict) -> None:
+    def __init__(self, typed_dict: Type) -> None:
         """
         Parameters:
             typed_dict (Type[TypedDict]): The TypedDict class

flask_inputfilter/input_filter.py

@@ -104,7 +104,7 @@ def decorator(
             """
 
             def wrapper(
-                *args, **kwargs
+                *args: Any, **kwargs: Any
             ) -> Union[Response, tuple[Any, dict[str, Any]]]:
                 """
                 Wrapper function to handle input validation and error handling

flask_inputfilter/mixins/external_api_mixin/_external_api_mixin.pyx

@@ -79,7 +79,7 @@ cdef class ExternalApiMixin:
         requestData["method"] = config.method
 
         try:
-            response = requests.request(**requestData)
+            response = requests.request(timeout=30, **requestData)
             result = response.json()
         except requests.exceptions.RequestException:
             if fallback is None:

flask_inputfilter/mixins/external_api_mixin/external_api_mixin.py

@@ -83,7 +83,7 @@ def call_external_api(
         request_data["method"] = config.method
 
         try:
-            response = requests.request(**request_data)
+            response = requests.request(timeout=30, **request_data)
             result = response.json()
         except requests.exceptions.RequestException:
             if fallback is None:

flask_inputfilter/validators/is_dataclass_validator.py

@@ -113,7 +113,7 @@ def __init__(
                 )
             )
 
-    def _format_error(self, error_type: str, **kwargs) -> str:
+    def _format_error(self, error_type: str, **kwargs: Any) -> str:
         """Format error message using template or custom message."""
         if self.error_message:
             return self.error_message

flask_inputfilter/validators/is_horizontal_image_validator.py

@@ -3,6 +3,7 @@
 import base64
 import binascii
 import io
+from typing import Any, Optional
 
 from PIL import Image
 from PIL.Image import Image as ImageType
@@ -41,10 +42,10 @@ def __init__(self):
 
     __slots__ = ("error_message",)
 
-    def __init__(self, error_message=None):
+    def __init__(self, error_message: Optional[str] = None) -> None:
         self.error_message = error_message
 
-    def validate(self, value):
+    def validate(self, value: Any) -> None:
         if not isinstance(value, (str, ImageType)):
             raise ValidationError(
                 "The value is not an image or its base 64 representation."

flask_inputfilter/validators/is_vertical_image_validator.py

@@ -42,7 +42,7 @@ def __init__(self):
 
     __slots__ = ("error_message",)
 
-    def __init__(self, error_message: Optional[str] = None):
+    def __init__(self, error_message: Optional[str] = None) -> None:
         self.error_message = (
             error_message or "The image is not vertically oriented."
         )