Merge pull request #87 from Leanplum/feature/fix-warnings

feat(deprecation): fixing deprecation warnings

Author: benmarten

AndroidSDK/src/com/leanplum/LeanplumPushService.java

@@ -350,6 +350,7 @@ private static void showNotification(Context context, Bundle message) {
     // level 26. For API level 26 and above we must use setImportance(int) for each notification
     // channel, not for each notification message.
     if (Build.VERSION.SDK_INT >= 16 && Build.VERSION.SDK_INT < 26) {
+      //noinspection deprecation
       builder.setPriority(Notification.PRIORITY_MAX);
     }
     builder.setAutoCancel(true);

AndroidSDK/src/com/leanplum/LeanplumResources.java

@@ -42,7 +42,9 @@
 
 // Description of resources.asrc file (we don't use this right nwo)
 // http://ekasiswanto.wordpress.com/2012/09/19/descriptions-of-androids-resources-arsc/
-
+// Suppressing deprecation warnings for Resource methods,
+// because the resource syncing feature will likely be refactored/replaced in the future.
+@SuppressWarnings("deprecation")
 public class LeanplumResources extends Resources {
   public LeanplumResources(Resources base) {
     super(base.getAssets(), base.getDisplayMetrics(), base.getConfiguration());

AndroidSDK/src/com/leanplum/LocationManagerImplementation.java

@@ -36,6 +36,7 @@
 import com.google.android.gms.common.api.GoogleApiClient.OnConnectionFailedListener;
 import com.google.android.gms.location.Geofence;
 import com.google.android.gms.location.Geofence.Builder;
+import com.google.android.gms.location.GeofencingRequest;
 import com.google.android.gms.location.LocationListener;
 import com.google.android.gms.location.LocationRequest;
 import com.google.android.gms.location.LocationServices;
@@ -264,6 +265,9 @@ private boolean isMetaDataSet() {
     }
   }
 
+  // Suppressing missing permission warning which since it is up to client to add location
+  // permission to their manifest.
+  @SuppressWarnings("MissingPermission")
   private void updateTrackedGeofences() {
     if (allGeofences == null || googleApiClient == null || !googleApiClient.isConnected()) {
       return;
@@ -282,8 +286,11 @@ private void updateTrackedGeofences() {
     }
     trackedGeofenceIds = new ArrayList<>();
     if (toBeTrackedGeofences != null && toBeTrackedGeofences.size() > 0) {
-      LocationServices.GeofencingApi.addGeofences(
-          googleApiClient, toBeTrackedGeofences, getTransitionPendingIntent());
+      GeofencingRequest request = new GeofencingRequest.Builder()
+          .addGeofences(toBeTrackedGeofences)
+          .build();
+      LocationServices.GeofencingApi.addGeofences(googleApiClient,
+          request, getTransitionPendingIntent());
       for (Geofence geofence : toBeTrackedGeofences) {
         trackedGeofenceIds.add(geofence.getRequestId());
         //TODO: stateBeforeBackground doesn't get persisted.
@@ -432,6 +439,9 @@ public void onLocationChanged(Location location) {
   /**
    * Request location for user location update if googleApiClient is connected.
    */
+  // Suppressing missing permission warning which since it is up to client to add location
+  // permission to their manifest.
+  @SuppressWarnings("MissingPermission")
   private void requestLocation() {
     if (!Leanplum.isLocationCollectionEnabled() || googleApiClient == null
         || !googleApiClient.isConnected()) {

AndroidSDK/src/com/leanplum/internal/ResourceQualifiers.java

@@ -80,6 +80,8 @@ public Object getMatch(String str) {
 
       @Override
       public boolean isMatch(Object value, Configuration config, DisplayMetrics display) {
+        // Suppressing deprecated locale.
+        //noinspection deprecation
         return config.locale.getLanguage().equals(value);
       }
     }),
@@ -94,6 +96,8 @@ public Object getMatch(String str) {
 
       @Override
       public boolean isMatch(Object value, Configuration config, DisplayMetrics display) {
+        // Suppressing deprecated locale.
+        //noinspection deprecation
         return config.locale.getCountry().toLowerCase().equals(value);
       }
     }),

AndroidSDK/src/com/leanplum/internal/Socket.java

@@ -48,6 +48,8 @@
  *
  * @author Andrew First, Ben Marten
  */
+// Suppressing deprecated apache dependency.
+@SuppressWarnings("deprecation")
 public class Socket {
   private static final String TAG = "Leanplum";
   private static final String EVENT_CONTENT_RESPONSE = "getContentResponse";

AndroidSDK/src/com/leanplum/internal/SocketIOClient.java

@@ -44,6 +44,8 @@
 import java.util.Arrays;
 import java.util.HashSet;
 
+// Suppressing deprecated apache dependency.
+@SuppressWarnings("deprecation")
 class SocketIOClient {
   interface Handler {
     void onConnect();

AndroidSDK/src/com/leanplum/internal/WebSocketClient.java

@@ -53,6 +53,8 @@
 import javax.net.ssl.SSLSocketFactory;
 import javax.net.ssl.TrustManager;
 
+// Suppressing deprecated apache dependency.
+@SuppressWarnings("deprecation")
 class WebSocketClient {
   private static final String TAG = "WebSocketClient";
 

AndroidSDK/src/com/leanplum/messagetemplates/BaseMessageDialog.java

@@ -441,7 +441,6 @@ public boolean onLongClick(View v) {
       webViewSettings.setMediaPlaybackRequiresUserGesture(false);
     }
     webViewSettings.setAppCacheEnabled(true);
-    webViewSettings.getSaveFormData();
     webViewSettings.setAllowFileAccess(true);
     webViewSettings.setJavaScriptEnabled(true);
     webViewSettings.setDomStorageEnabled(true);