Merge pull request #37 from Leanplum/feature/fix-LP-4789

Enuviel · Enuviel · commit 1768598614fc · 2017-07-11T13:20:28.000-07:00
fix(NPE) wrapping creation notification in try{}catch block to avoid …
diff --git a/AndroidSDK/src/com/leanplum/LeanplumPushService.java b/AndroidSDK/src/com/leanplum/LeanplumPushService.java
@@ -346,7 +346,15 @@ private static void showNotification(Context context, Bundle message) {
         notificationId = value.hashCode();
       }
     }
-    notificationManager.notify(notificationId, builder.build());
+
+    try {
+      notificationManager.notify(notificationId, builder.build());
+    } catch (NullPointerException e) {
+      Log.e("Unable to show push notification.", e);
+    } catch (Throwable t) {
+      Log.e("Unable to show push notification.", t);
+      Util.handleException(t);
+    }
   }
 
   static void openNotification(Context context, final Bundle notification) {

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,15 @@ private static void showNotification(Context context, Bundle message) {`
`346`	`346`	`notificationId = value.hashCode();`
`347`	`347`	`}`
`348`	`348`	`}`
`349`		`- notificationManager.notify(notificationId, builder.build());`
	`349`	`+`
	`350`	`+ try {`
	`351`	`+ notificationManager.notify(notificationId, builder.build());`
	`352`	`+ } catch (NullPointerException e) {`
	`353`	`+ Log.e("Unable to show push notification.", e);`
	`354`	`+ } catch (Throwable t) {`
	`355`	`+ Log.e("Unable to show push notification.", t);`
	`356`	`+ Util.handleException(t);`
	`357`	`+ }`
`350`	`358`	`}`
`351`	`359`
`352`	`360`	`static void openNotification(Context context, final Bundle notification) {`