refactor unsent/requeststosend

Author: e7mac

AndroidSDKCore/src/main/java/com/leanplum/internal/Request.java

@@ -480,7 +480,14 @@ protected Void doInBackground(Void... params) {
     });
   }
 
-  private void sendRequests() {
+
+  private static class RequestsWithEncoding {
+    List<Map<String, Object>> unsentRequests;
+    List<Map<String, Object>> requestsToSend;
+    String jsonEncodedString;
+  }
+
+  private RequestsWithEncoding getRequestsWithEncodedString() {
     List<Map<String, Object>> unsentRequests = new ArrayList<>();
     List<Map<String, Object>> requestsToSend;
     // Check if we have localErrors, if yes then we will send only errors to the server.
@@ -496,6 +503,23 @@ private void sendRequests() {
       requestsToSend = removeIrrelevantBackgroundStartRequests(unsentRequests);
     }
 
+    String jsonEncodedRequestsToSend = jsonEncodeUnsentRequests(unsentRequests);
+
+    RequestsWithEncoding requestsWithEncoding = new RequestsWithEncoding();
+    requestsWithEncoding.unsentRequests = unsentRequests;
+    requestsWithEncoding.requestsToSend= requestsToSend;
+    requestsWithEncoding.jsonEncodedString = jsonEncodedRequestsToSend;
+
+    return requestsWithEncoding;
+  }
+
+  private void sendRequests() {
+    RequestsWithEncoding requestsWithEncoding = getRequestsWithEncodedString();
+
+    List<Map<String, Object>> unsentRequests = requestsWithEncoding.unsentRequests;
+    List<Map<String, Object>> requestsToSend = requestsWithEncoding.requestsToSend;
+    String jsonEncodedString = requestsWithEncoding.jsonEncodedString;
+
     if (requestsToSend.isEmpty()) {
       return;
     }
@@ -504,7 +528,7 @@ private void sendRequests() {
     if (!Request.attachApiKeys(multiRequestArgs)) {
       return;
     }
-    multiRequestArgs.put(Constants.Params.DATA, jsonEncodeUnsentRequests(requestsToSend));
+    multiRequestArgs.put(Constants.Params.DATA, jsonEncodedString);
     multiRequestArgs.put(Constants.Params.SDK_VERSION, Constants.LEANPLUM_VERSION);
     multiRequestArgs.put(Constants.Params.ACTION, Constants.Methods.MULTI);
     multiRequestArgs.put(Constants.Params.TIME, Double.toString(new Date().getTime() / 1000.0));