Lp 10446 start call back variable call back (#356)

* fix for no network response

* tests added

* review update

* fix

Author: hrishileanplum

AndroidSDKCore/src/main/java/com/leanplum/Leanplum.java

@@ -740,9 +740,9 @@ private static void handleApiResponse(JSONObject response, List<Map<String, Obje
       if (!LeanplumInternal.hasStarted()) {
         // Set start response to null.
         request.onApiResponse(null);
-        Leanplum.handleStartResponse(lastStartResponse);
       }
     }
+    Leanplum.handleStartResponse(lastStartResponse);
   }
 
   @VisibleForTesting

AndroidSDKTests/src/test/java/com/leanplum/LeanplumTest.java

@@ -1671,4 +1671,69 @@ public void variablesChanged() {
 
     assertEquals(4, VarCache.variants().size());
   }
+
+  @Test
+  public void testStartChangeCallBackForOffline() throws Exception {
+    final Semaphore semaphore = new Semaphore(1);
+    semaphore.acquire();
+
+    //Offline Mode.
+     ResponseHelper.seedResponseNull();
+
+    // Expected request params.
+    final HashMap<String, Object> expectedRequestParams = CollectionUtil.newHashMap(
+        "city", "(detect)",
+        "country", "(detect)",
+        "location", "(detect)",
+        "region", "(detect)",
+        "locale", "en_US"
+    );
+
+    // Validate request.
+    // Validate request.
+    RequestHelper.addRequestHandler(new RequestHelper.RequestHandler() {
+      @Override
+      public void onRequest(String httpMethod, String apiMethod, Map<String, Object> params) {
+        assertEquals(Constants.Methods.START, apiMethod);
+        assertTrue(params.keySet().containsAll(expectedRequestParams.keySet()));
+        assertTrue(params.values().containsAll(expectedRequestParams.values()));
+      }
+    });
+
+
+    Leanplum.start(mContext, new StartCallback() {
+      @Override
+      public void onResponse(boolean success) {
+        assertTrue(success);
+        semaphore.release();
+      }
+    });
+    assertTrue(Leanplum.hasStarted());
+    
+  }
+
+  @Test
+  public void testVariableChangeCallBacksForOffline() throws Exception {
+    final Semaphore semaphore = new Semaphore(1);
+
+    semaphore.acquire();
+
+    // Seed getVars response.
+    ResponseHelper.seedResponseNull();
+
+    RequestHelper.addRequestHandler(new RequestHelper.RequestHandler() {
+      @Override
+      public void onRequest(String httpMethod, String apiMethod, Map<String, Object> params) {
+        assertEquals(Constants.Methods.GET_VARS, apiMethod);
+      }
+    });
+
+    Leanplum.forceContentUpdate(new VariablesChangedCallback() {
+      @Override
+      public void variablesChanged() {
+        semaphore.release();
+      }
+    });
+
+  }
 }

AndroidSDKTests/src/test/java/com/leanplum/_whitebox/utilities/ResponseHelper.java

@@ -74,4 +74,18 @@ public static void seedResponse(String filename) {
       Log.e("ResponseHelper", "Unable to seed response from file: " + filename);
     }
   }
+
+  /**
+   * Seeds the Null response to Util.getResponse method.
+   *
+   */
+
+
+  public static void seedResponseNull() {
+    try {
+      doReturn(false).when(Util.class, Util.isConnected());
+    } catch (Exception e) {
+      Log.e("ResponseHelper", "Unable to seed response from file: ");
+    }
+  }
 }