address comments

Author: e7mac

AndroidSDKCore/src/main/java/com/leanplum/internal/Request.java

@@ -481,6 +481,12 @@ protected Void doInBackground(Void... params) {
   }
 
 
+  /**
+   * This class wraps the unsent requests, requests that we need to send
+   * and the JSON encoded string. Wrapping it in the class allows us to
+   * retain consistency in the requests we are sending and the actual
+   * JSON string.
+   */
   static class RequestsWithEncoding {
     List<Map<String, Object>> unsentRequests;
     List<Map<String, Object>> requestsToSend;
@@ -517,7 +523,7 @@ protected RequestsWithEncoding getRequestsWithEncodedStringStoredRequests(double
       String jsonEncodedRequestsToSend;
       RequestsWithEncoding requestsWithEncoding = new RequestsWithEncoding();
 
-      if (fraction < 0.01) {
+      if (fraction < 0.01) { //base case
         unsentRequests = new ArrayList<>(0);
         requestsToSend = new ArrayList<>(0);
       } else {
@@ -532,6 +538,7 @@ protected RequestsWithEncoding getRequestsWithEncodedStringStoredRequests(double
 
       return requestsWithEncoding;
     } catch (OutOfMemoryError E) {
+      // half the requests will need less memory, recursively
       return getRequestsWithEncodedStringStoredRequests(0.5 * fraction);
     }
   }

AndroidSDKTests/src/test/java/com/leanplum/LeanplumTest.java

@@ -403,9 +403,11 @@ public void testCrashes() throws Exception {
 
     request1.sendEventually();
     request2.sendEventually();
+
+    final double fraction = 1.0;
     // Get a number of events in the database.
     // Expectation: 2 events.
-    List unsentRequests = request1.getUnsentRequests(1.0);
+    List unsentRequests = request1.getUnsentRequests(fraction);
     assertNotNull(unsentRequests);
     assertEquals(2, unsentRequests.size());
 
@@ -427,7 +429,7 @@ public void testCrashes() throws Exception {
 
     // Get a number of events in the database. Checks if ours two events still here.
     // Expectation: 2 events.
-    unsentRequests = request1.getUnsentRequests(1.0);
+    unsentRequests = request1.getUnsentRequests(fraction);
     assertNotNull(unsentRequests);
     assertEquals(2, unsentRequests.size());
 
@@ -444,7 +446,7 @@ public void onRequest(String httpMethod, String apiMethod, Map<String, Object> p
 
     // Get a number of events in the database. Make sure we sent all events.
     // Expectation: 0 events.
-    unsentRequests = request1.getUnsentRequests(1.0);
+    unsentRequests = request1.getUnsentRequests(fraction);
     assertNotNull(unsentRequests);
     assertEquals(0, unsentRequests.size());
 

AndroidSDKTests/src/test/java/com/leanplum/internal/RequestTest.java

@@ -249,9 +249,8 @@ public void testJsonEncodeUnsentRequestsWithExceptionLargeNumbers() throws NoSuc
     requestsWithEncoding = request.getRequestsWithEncodedStringStoredRequests(1.0);
     assertEquals(1250, requestsWithEncoding.unsentRequests.size());
 
-    // Throw OOM on > 0 requests
-    // Expectation: 0 requests returned but no crash
-
+    // Throw OOM on serializing any finite number of requests (extreme condition)
+    // Expectation: Determine only 0 requests to be sent
     when(request.getUnsentRequests(not(eq(0)))).thenThrow(OutOfMemoryError.class);
     requestsWithEncoding = request.getRequestsWithEncodedStringStoredRequests(1.0);