Fix error logging (#430)

Author: hborisoff

AndroidSDKCore/src/main/java/com/leanplum/LeanplumInbox.java

@@ -366,7 +366,7 @@ public void response(JSONObject response) {
 
           JSONObject messagesDict = response.optJSONObject(Constants.Keys.INBOX_MESSAGES);
           if (messagesDict == null) {
-            Log.e("No inbox messages found in the response from the server.", response);
+            Log.e("No inbox messages found in the response from the server. %s", response);
             return;
           }
           int unreadCount = 0;

AndroidSDKCore/src/main/java/com/leanplum/annotations/Parser.java

@@ -65,10 +65,9 @@ public void handle(Var<T> variable) {
             field.setAccessible(false);
           }
         } catch (IllegalArgumentException e) {
-          Log.e("Leanplum", "Invalid value " + var.value() +
-              " for field " + var.name(), e);
+          Log.e("Invalid value " + var.value() + " for field " + var.name(), e);
         } catch (IllegalAccessException e) {
-          Log.e("Leanplum", "Error setting value for field " + var.name(), e);
+          Log.e("Error setting value for field " + var.name(), e);
         }
       }
     });
@@ -100,10 +99,9 @@ public void handle(Var<String> variable) {
             field.setAccessible(false);
           }
         } catch (IllegalArgumentException e) {
-          Log.e("Leanplum", "Invalid value " + var.value() +
-              " for field " + var.name(), e);
+          Log.e("Invalid value " + var.value() + " for field " + var.name(), e);
         } catch (IllegalAccessException e) {
-          Log.e("Leanplum", "Error setting value for field " + var.name(), e);
+          Log.e("Error setting value for field " + var.name(), e);
         }
       }
     });
@@ -118,7 +116,7 @@ public static void parseVariables(Object... instances) {
         parseVariablesHelper(instance, instance.getClass());
       }
     } catch (Throwable t) {
-      Log.e("Leanplum", "Error parsing variables", t);
+      Log.e("Error parsing variables", t);
     }
   }
 
@@ -131,7 +129,7 @@ public static void parseVariablesForClasses(Class<?>... classes) {
         parseVariablesHelper(null, clazz);
       }
     } catch (Throwable t) {
-      Log.e("Leanplum", "Error parsing variables", t);
+      Log.e("Error parsing variables", t);
     }
   }
 

AndroidSDKCore/src/main/java/com/leanplum/internal/Log.java

@@ -48,6 +48,14 @@ public static void e(String msg, Object... args) {
     log(LogType.ERROR, msg, args);
   }
 
+  public static void e(String msg, Throwable throwable) {
+    if (msg != null && msg.contains("%s")) {
+      log(LogType.ERROR, msg, getStackTraceString(throwable));
+    } else {
+      log(LogType.ERROR, msg + "\n" + getStackTraceString(throwable));
+    }
+  }
+
   public static void i(String msg, Object... args) {
     log(LogType.INFO, msg, args);
   }

AndroidSDKCore/src/main/java/com/leanplum/internal/RequestUtil.java

@@ -28,7 +28,7 @@ public static JSONObject getResponseForId(JSONObject response, String reqId) {
                 }
             }
         } catch (JSONException e) {
-            Log.e("Could not get response for id: ", reqId, e);
+            Log.e("Could not get response for id: " + reqId, e);
             return null;
         }
         return null;

AndroidSDKPush/src/main/java/com/leanplum/LeanplumPushService.java

@@ -344,7 +344,7 @@ private static void showNotification(Context context, final Bundle message) {
           customizer.customize(notificationCompatBuilder, message);
         }
       } catch (Throwable t) {
-        Log.e("Unable to customize push notification: ", Log.getStackTraceString(t));
+        Log.e("Unable to customize push notification: %s", Log.getStackTraceString(t));
         return;
       }
     } else {