Fix Leanplum.hasStarted to be true when device is offline (#439)

Author: hborisoff

AndroidSDKCore/src/main/java/com/leanplum/internal/RequestSender.java

@@ -228,7 +228,7 @@ private void sendSync(@NonNull Request request) {
 
     if (Constants.isDevelopmentModeEnabled || RequestType.IMMEDIATE.equals(request.getType())) {
       try {
-        if (validateConfig()) {
+        if (validateConfig(request)) {
           sendRequests();
         }
       } catch (Throwable t) {
@@ -237,7 +237,7 @@ private void sendSync(@NonNull Request request) {
     }
   }
 
-  private boolean validateConfig() {
+  private boolean validateConfig(@NonNull Request request) {
     if (APIConfig.getInstance().appId() == null) {
       Log.e("Cannot send request. appId is not set.");
       return false;
@@ -250,6 +250,9 @@ private boolean validateConfig() {
 
     if (!Util.isConnected()) {
       Log.d("Device is offline, will try sending requests again later.");
+      if (request.error != null) {
+        request.error.error(new Exception("Leanplum: device is offline"));
+      }
       return false;
     }
 

AndroidSDKTests/src/test/java/com/leanplum/LeanplumTest.java

@@ -1654,48 +1654,41 @@ public void variablesChanged() {
     assertEquals(4, VarCache.variants().size());
   }
 
-//  TODO: Currently hasStarted flag is not set if network is down.
-//   This must be discussed and fixed as well.
-//
-//  @Test
-//  public void testStartChangeCallBackForOffline() throws Exception {
-//    final Semaphore semaphore = new Semaphore(1);
-//    semaphore.acquire();
-//
-//    //Offline Mode.
-//     ResponseHelper.seedResponseNull();
-//
-//    // Expected request params.
-//    final HashMap<String, Object> expectedRequestParams = CollectionUtil.newHashMap(
-//        "city", "(detect)",
-//        "country", "(detect)",
-//        "location", "(detect)",
-//        "region", "(detect)",
-//        "locale", "en_US"
-//    );
-//
-//    // Validate request.
-//    // Validate request.
-//    RequestHelper.addRequestHandler(new RequestHelper.RequestHandler() {
-//      @Override
-//      public void onRequest(String httpMethod, String apiMethod, Map<String, Object> params) {
-//        assertEquals(RequestBuilder.ACTION_START, apiMethod);
-//        assertTrue(params.keySet().containsAll(expectedRequestParams.keySet()));
-//        assertTrue(params.values().containsAll(expectedRequestParams.values()));
-//      }
-//    });
-//
-//
-//    Leanplum.start(mContext, new StartCallback() {
-//      @Override
-//      public void onResponse(boolean success) {
-//        assertTrue(success);
-//        semaphore.release();
-//      }
-//    });
-//    assertTrue(Leanplum.hasStarted());
-//
-//  }
+  @Test
+  public void testStartChangeCallBackForOffline() throws Exception {
+    //Offline Mode.
+     ResponseHelper.seedResponseNull();
+
+    // Expected request params.
+    final HashMap<String, Object> expectedRequestParams = CollectionUtil.newHashMap(
+        "city", "(detect)",
+        "country", "(detect)",
+        "location", "(detect)",
+        "region", "(detect)",
+        "locale", "en_US"
+    );
+
+    // Validate request.
+    // Validate request.
+    RequestHelper.addRequestHandler(new RequestHelper.RequestHandler() {
+      @Override
+      public void onRequest(String httpMethod, String apiMethod, Map<String, Object> params) {
+        assertEquals(RequestBuilder.ACTION_START, apiMethod);
+        assertTrue(params.keySet().containsAll(expectedRequestParams.keySet()));
+        assertTrue(params.values().containsAll(expectedRequestParams.values()));
+      }
+    });
+
+
+    Leanplum.start(mContext, new StartCallback() {
+      @Override
+      public void onResponse(boolean success) {
+        assertFalse(success); // in offline mode the success flag is false and isStarted is true
+      }
+    });
+    assertTrue(Leanplum.hasStarted());
+
+  }
 
   @Test
   public void testVariableChangeCallBacksForOffline() throws Exception {