Skip to content

Commit 939bc66

Browse files
authored
Fix requests to send (#252)
1 parent d644c98 commit 939bc66

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

AndroidSDKCore/src/main/java/com/leanplum/internal/Request.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ private RequestsWithEncoding getRequestsWithEncodedStringForErrors() {
529529
unsentRequests.add(error);
530530
}
531531
requestsToSend = unsentRequests;
532-
jsonEncodedRequestsToSend = jsonEncodeUnsentRequests(unsentRequests);
532+
jsonEncodedRequestsToSend = jsonEncodeRequests(unsentRequests);
533533

534534
RequestsWithEncoding requestsWithEncoding = new RequestsWithEncoding();
535535
// for errors, we send all unsent requests so they are identical
@@ -556,7 +556,7 @@ protected RequestsWithEncoding getRequestsWithEncodedStringStoredRequests(double
556556
requestsToSend = removeIrrelevantBackgroundStartRequests(unsentRequests);
557557
}
558558

559-
jsonEncodedRequestsToSend = jsonEncodeUnsentRequests(unsentRequests);
559+
jsonEncodedRequestsToSend = jsonEncodeRequests(requestsToSend);
560560
requestsWithEncoding.unsentRequests = unsentRequests;
561561
requestsWithEncoding.requestsToSend = requestsToSend;
562562
requestsWithEncoding.jsonEncodedString = jsonEncodedRequestsToSend;
@@ -750,7 +750,7 @@ private static List<Map<String, Object>> removeIrrelevantBackgroundStartRequests
750750
return relevantRequests;
751751
}
752752

753-
protected static String jsonEncodeUnsentRequests(List<Map<String, Object>> requestData) {
753+
protected static String jsonEncodeRequests(List<Map<String, Object>> requestData) {
754754
Map<String, Object> data = new HashMap<>();
755755
data.put(Constants.Params.DATA, requestData);
756756
return JsonConverter.toJson(data);

AndroidSDKTests/src/test/java/com/leanplum/internal/RequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ public void testJsonEncodeUnsentRequests() {
346346
@Test
347347
public void testGetRequestsWithEncodedStringStoredRequests() {
348348
List<Map<String, Object>> requests = mockRequests(4);
349-
String json = Request.jsonEncodeUnsentRequests(requests);
349+
String json = Request.jsonEncodeRequests(requests);
350350

351351
final String expectedJson = "{\"data\":[{\"0\":\"testData\"},{\"1\":\"testData\"},{\"2\":\"testData\"},{\"3\":\"testData\"}]}";
352352
assertEquals(json, expectedJson);

0 commit comments

Comments
 (0)