Skip to content

Commit 96d5d99

Browse files
author
Sayaan Saha
committed
Updated
1 parent 9c79544 commit 96d5d99

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

AndroidSDKCore/src/main/java/com/leanplum/internal/Request.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -489,14 +489,13 @@ private void sendNow() {
489489
return;
490490
}
491491

492-
//use something like a callback interface and pass it through here
493-
this.sendEventually(); //write
492+
this.sendEventually();
494493

495494
Util.executeAsyncTask(true, new AsyncTask<Void, Void, Void>() {
496495
@Override
497496
protected Void doInBackground(Void... params) {
498497
try {
499-
sendRequests(); // read
498+
sendRequests();
500499
} catch (Throwable t) {
501500
Util.handleException(t);
502501
}

AndroidSDKTests/src/test/java/com/leanplum/internal/RequestTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ public void setUp() {
7272
* Test that read writes happened sequentially when calling sendNow().
7373
*/
7474
@Test
75-
public void testMultiThreaded() {
75+
public void testSequenceOfDatabaseOperations() {
7676
Map<String, Object> params = new HashMap<>();
7777
params.put("data1", "value1");
7878
params.put("data2", "value2");
7979
ThreadWaiter waiter = new ThreadWaiter();
80-
Request request = new Request("POST", Constants.Methods.START, params);
80+
Request request = new Request("POST", Constants.Methods.START, params, waiter);
8181
request.setAppId("fskadfshdbfa", "wee5w4waer422323");
8282
request.sendIfConnected();
8383
waiter.assertCallSequence();
@@ -361,7 +361,7 @@ public void afterWrite() {
361361
}
362362

363363
public void assertCallSequence() {
364-
assert(t4.isBefore(t1));
364+
assertTrue(t4.isBefore(t1));
365365
}
366366
}
367367
}

0 commit comments

Comments
 (0)