Skip to content

Commit 9802c8a

Browse files
committed
feat(deprecation): fixing pr comments
1 parent 6ede507 commit 9802c8a

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

AndroidSDK/src/com/leanplum/LeanplumResources.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242

4343
// Description of resources.asrc file (we don't use this right nwo)
4444
// http://ekasiswanto.wordpress.com/2012/09/19/descriptions-of-androids-resources-arsc/
45+
// We should switch from deprecated API to newer one.
4546
@SuppressWarnings("deprecation")
4647
public class LeanplumResources extends Resources {
4748
public LeanplumResources(Resources base) {

AndroidSDK/src/com/leanplum/internal/ResourceQualifiers.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ public Object getMatch(String str) {
8080

8181
@Override
8282
public boolean isMatch(Object value, Configuration config, DisplayMetrics display) {
83+
// We should switch to getLocale() instead of reading directly locale.
8384
//noinspection deprecation
8485
return config.locale.getLanguage().equals(value);
8586
}
@@ -95,6 +96,7 @@ public Object getMatch(String str) {
9596

9697
@Override
9798
public boolean isMatch(Object value, Configuration config, DisplayMetrics display) {
99+
// We should switch to getLocale() instead of reading directly locale.
98100
//noinspection deprecation
99101
return config.locale.getCountry().toLowerCase().equals(value);
100102
}

0 commit comments

Comments
 (0)