Add immutable flag to all pending intents. Mandatory for Android 12. (#450)

Author: hborisoff

AndroidSDKCore/src/main/java/com/leanplum/utils/BuildUtil.java

@@ -20,6 +20,7 @@
  */
 package com.leanplum.utils;
 
+import android.app.PendingIntent;
 import android.content.Context;
 import android.os.Build;
 
@@ -53,4 +54,17 @@ private static int getTargetSdkVersion(Context context) {
     }
     return targetSdk;
   }
+
+  /**
+   * Adds immutable property to the intent flags. Mandatory when targeting API 31.
+   *
+   * @param flags The default flags.
+   * @return Flags with additional immutable property set.
+   */
+  public static int createIntentFlags(int flags) {
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
+      return flags | PendingIntent.FLAG_IMMUTABLE;
+    }
+    return flags;
+  }
 }

AndroidSDKLocation/src/main/java/com/leanplum/LocationManagerImplementation.java

@@ -46,6 +46,7 @@
 import com.leanplum.internal.Log;
 import com.leanplum.internal.Util;
 import com.leanplum.models.GeofenceEventType;
+import com.leanplum.utils.BuildUtil;
 import com.leanplum.utils.SharedPreferencesUtil;
 
 import java.util.ArrayList;
@@ -395,7 +396,8 @@ private String getRegionName(String geofenceRequestId) {
   private PendingIntent getTransitionPendingIntent() {
     Context context = Leanplum.getContext();
     Intent intent = new Intent(context, ReceiveTransitionsIntentService.class);
-    return PendingIntent.getService(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
+    return PendingIntent.getService(context, 0, intent,
+        BuildUtil.createIntentFlags(PendingIntent.FLAG_UPDATE_CURRENT));
   }
 
   @Override

AndroidSDKPush/src/main/java/com/leanplum/LeanplumPushService.java

@@ -308,7 +308,7 @@ private static void showNotification(Context context, final Bundle message) {
     intent.addCategory("lpAction");
     intent.putExtras(message);
     PendingIntent contentIntent = PendingIntent.getBroadcast(context.getApplicationContext(),
-        new Random().nextInt(), intent, 0);
+        new Random().nextInt(), intent, BuildUtil.createIntentFlags(0));
 
     String title = Util.getApplicationName(context.getApplicationContext());
     if (message.getString("title") != null) {
@@ -651,7 +651,8 @@ public static void unregister() {
     try {
       Intent unregisterIntent = new Intent("com.google.android.c2dm.intent.UNREGISTER");
       Context context = Leanplum.getContext();
-      unregisterIntent.putExtra("app", PendingIntent.getBroadcast(context, 0, new Intent(), 0));
+      unregisterIntent.putExtra("app",
+          PendingIntent.getBroadcast(context, 0, new Intent(), BuildUtil.createIntentFlags(0)));
       unregisterIntent.setPackage("com.google.android.gms");
       context.startService(unregisterIntent);
     } catch (Throwable t) {
@@ -686,7 +687,7 @@ static void showDeviceRegisteredPush(Context context, Context currentContext) {
           .setContentTitle("Leanplum")
           .setContentText("Your device is registered.");
       builder.setContentIntent(PendingIntent.getActivity(
-          currentContext.getApplicationContext(), 0, new Intent(), 0));
+          currentContext.getApplicationContext(), 0, new Intent(), BuildUtil.createIntentFlags(0)));
       NotificationManager mNotificationManager =
           (NotificationManager) currentContext.getSystemService(
               Context.NOTIFICATION_SERVICE);

AndroidSDKPush/src/main/java/com/leanplum/internal/LeanplumLocalPushHelper.java

@@ -31,6 +31,7 @@
 import com.leanplum.ActionContext;
 import com.leanplum.Leanplum;
 import com.leanplum.LeanplumLocalPushListenerService;
+import com.leanplum.utils.BuildUtil;
 import com.leanplum.utils.SharedPreferencesUtil;
 
 import java.io.Serializable;
@@ -71,7 +72,7 @@ static boolean scheduleLocalPush(ActionContext actionContext, String messageId,
         } else if (existingEta >= eta) {
           PendingIntent existingIntent = PendingIntent.getBroadcast(
               context, messageId.hashCode(), intentAlarm,
-              PendingIntent.FLAG_UPDATE_CURRENT);
+              BuildUtil.createIntentFlags(PendingIntent.FLAG_UPDATE_CURRENT));
           alarmManager.cancel(existingIntent);
         }
       }
@@ -123,7 +124,7 @@ static boolean scheduleLocalPush(ActionContext actionContext, String messageId,
       // Schedule notification.
       PendingIntent operation = PendingIntent.getBroadcast(
           context, messageId.hashCode(), intentAlarm,
-          PendingIntent.FLAG_UPDATE_CURRENT);
+          BuildUtil.createIntentFlags(PendingIntent.FLAG_UPDATE_CURRENT));
 
       if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT && Util.isXiaomiDevice()) {
         // Improve delivery of local pushes, particularly for offline and locked devices.
@@ -156,7 +157,8 @@ static void cancelLocalPush(Context context, String messageId) {
       Intent intentAlarm = LeanplumLocalPushListenerService.getIntent(context);
       AlarmManager alarmManager = (AlarmManager) context.getSystemService(Context.ALARM_SERVICE);
       PendingIntent existingIntent = PendingIntent.getBroadcast(
-          context, messageId.hashCode(), intentAlarm, PendingIntent.FLAG_UPDATE_CURRENT);
+          context, messageId.hashCode(), intentAlarm,
+          BuildUtil.createIntentFlags(PendingIntent.FLAG_UPDATE_CURRENT));
       if (alarmManager != null && existingIntent != null) {
         alarmManager.cancel(existingIntent);
       }